From fd85a1c2052f4b33eab1b4411a3044b175c7d444 Mon Sep 17 00:00:00 2001 From: jakubroch Date: Thu, 2 Apr 2026 15:00:48 +0200 Subject: [PATCH 1/2] fix: cloudinary config is always undefined --- src/utils/fetch-config.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/utils/fetch-config.js b/src/utils/fetch-config.js index e34fef38..cad9a4c1 100644 --- a/src/utils/fetch-config.js +++ b/src/utils/fetch-config.js @@ -1,7 +1,10 @@ +import pick from 'lodash/pick'; import { defaultProfiles } from 'cloudinary-video-player-profiles'; import { isRawUrl, getCloudinaryUrlPrefix } from '../plugins/cloudinary/url-helpers'; +import { CLOUDINARY_CONFIG_PARAM } from '../video-player.const'; import { utf8ToBase64 } from '../utils/utf8Base64'; import { appendQueryParams } from './querystring'; +import { convertKeysToSnakeCase } from './object'; const isDefaultProfile = (profileName) => !!defaultProfiles.find(({ name }) => profileName === name); @@ -15,13 +18,23 @@ const getDefaultProfileConfig = (profileName) => { return profile.config; }; +const getCloudinaryConfigFromOptions = (options) => { + if (options.cloudinaryConfig) { + return options.cloudinaryConfig; + } + + const fromFlat = pick(convertKeysToSnakeCase(options), CLOUDINARY_CONFIG_PARAM); + return Object.assign({}, fromFlat, options.cloudinary || {}); +}; + const fetchConfig = async (options) => { - const { profile, publicId, cloudinaryConfig, type = 'upload', videoConfig, allowUsageReport = true } = options; + const { profile, publicId, type = 'upload', videoConfig, allowUsageReport = true } = options; if (profile && isDefaultProfile(profile)) { return getDefaultProfileConfig(profile); } + const cloudinaryConfig = getCloudinaryConfigFromOptions(options); const urlPrefix = getCloudinaryUrlPrefix(cloudinaryConfig) + '/_applet_/video_service'; const queryParams = allowUsageReport ? { _s: `vp-${VERSION}` } : null; From c34d81ab4790082edc307bf5cb2d74e82bc42b03 Mon Sep 17 00:00:00 2001 From: jakubroch Date: Thu, 2 Apr 2026 15:27:29 +0200 Subject: [PATCH 2/2] fix: cloudinaryConfig --- src/utils/fetch-config.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils/fetch-config.js b/src/utils/fetch-config.js index cad9a4c1..8de092d7 100644 --- a/src/utils/fetch-config.js +++ b/src/utils/fetch-config.js @@ -23,8 +23,8 @@ const getCloudinaryConfigFromOptions = (options) => { return options.cloudinaryConfig; } - const fromFlat = pick(convertKeysToSnakeCase(options), CLOUDINARY_CONFIG_PARAM); - return Object.assign({}, fromFlat, options.cloudinary || {}); + const snakeCaseCloudinaryConfig = pick(convertKeysToSnakeCase(options), CLOUDINARY_CONFIG_PARAM); + return Object.assign({}, snakeCaseCloudinaryConfig); }; const fetchConfig = async (options) => {