Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP rework #47

Draft
wants to merge 1 commit into
base: master
from

Conversation

@arturkulig
Copy link
Collaborator

commented Oct 8, 2019

@mayashavin last time @asisayag2 and I spoke, he suggested I point you to these. There are three issues with the PR that you have already merged into master:

  1. I've seen and appreciate unpacking utility functions into separate files
  2. "nextTick" of Vue was still there and this is cannot be used for cases that should work in SSR, only for some browser-run-time features
  3. SSR test case did not include CldTransformation
  4. some of the modified tests are failing

Also if you will find some time and you actually can do it (not sure if it is locked/protected), please revert master to previous state, but that is not necessary - we can deal with it if it becomes a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.