Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #23 responsive feature #49

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@arturkulig
Copy link
Collaborator

arturkulig commented Nov 4, 2019

No description provided.

@asisayag2 asisayag2 requested a review from mayashavin Nov 4, 2019
<div class="cld-image">
<img v-bind="imageAttrs" :style="style"/>
<div class="cld-image" :style="style">
<img v-bind="imageAttrs" :style="style" />

This comment has been minimized.

Copy link
@mayashavin

mayashavin Nov 5, 2019

Contributor

Do we still need this?

This comment has been minimized.

Copy link
@arturkulig

arturkulig Nov 6, 2019

Author Collaborator

What do you mean by "this"?

This comment has been minimized.

Copy link
@arturkulig

arturkulig Nov 6, 2019

Author Collaborator

...and in any case I've added that cause resizing was built around having a single node - just img. Now both have to adapt to parent node size, so both have the size adjusting styles.

};
},
shouldMeasureSize() {
return !this.responsive;
return this.responsive !== false;

This comment has been minimized.

Copy link
@mayashavin

mayashavin Nov 5, 2019

Contributor

is there any difference or advantage in writing like this instead of !this.responsive?

This comment has been minimized.

Copy link
@arturkulig

arturkulig Nov 6, 2019

Author Collaborator

produces empty string and it should mean 'default value', yet here was interpreted as no value

@mayashavin mayashavin merged commit fafa8c0 into master Nov 6, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mayashavin mayashavin deleted the issue-23 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.