From 93671826a94502d51cab388223931aaaea5f4afe Mon Sep 17 00:00:00 2001 From: Dugi Surdulli Date: Fri, 11 Sep 2020 16:16:32 -0400 Subject: [PATCH 1/2] Fit instead of scale for crops --- .../php/class-media.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php b/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php index 7cf4a4dde..5f1ab9183 100644 --- a/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php +++ b/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php @@ -497,7 +497,7 @@ public function get_crop( $url, $attachment_id ) { 'wpsize' => $size_name, 'width' => $size['width'], 'height' => $size['height'], - 'crop' => $cropped ? 'fill' : 'scale', + 'crop' => $cropped ? 'fill' : 'fit', ); if ( $cropped ) { $wp_size['gravity'] = 'auto'; From 9c333a670f383ff8b681b7070a93a975f40fa1e9 Mon Sep 17 00:00:00 2001 From: Dugi Surdulli Date: Mon, 14 Sep 2020 09:21:07 -0400 Subject: [PATCH 2/2] Add ratio check --- .../php/class-media.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php b/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php index 5f1ab9183..4984a571b 100644 --- a/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php +++ b/cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/class-media.php @@ -488,7 +488,7 @@ public function get_crop( $url, $attachment_id ) { $additional_sizes = wp_get_additional_image_sizes(); foreach ( $meta['sizes'] as $size_name => $size ) { if ( $file === $size['file'] ) { - $cropped = false; + $cropped = ! wp_image_matches_ratio( $meta['width'], $meta['height'], $size['width'], $size['height'] ); if ( isset( $additional_sizes[ $size_name ]['crop'] ) ) { $cropped = $additional_sizes[ $size_name ]['crop']; } @@ -497,7 +497,7 @@ public function get_crop( $url, $attachment_id ) { 'wpsize' => $size_name, 'width' => $size['width'], 'height' => $size['height'], - 'crop' => $cropped ? 'fill' : 'fit', + 'crop' => $cropped ? 'fill' : 'scale', ); if ( $cropped ) { $wp_size['gravity'] = 'auto';