From 696e214f00e002c860ff61d2569b3654971b26ba Mon Sep 17 00:00:00 2001
From: Marco Pereirinha <marco.pereirinha@xwp.co>
Date: Mon, 30 Nov 2020 18:24:50 +0000
Subject: [PATCH 1/3] Add test version

---
 phpcs.xml.dist | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/phpcs.xml.dist b/phpcs.xml.dist
index c0f1e618b..e9f8e9237 100644
--- a/phpcs.xml.dist
+++ b/phpcs.xml.dist
@@ -1,5 +1,8 @@
 <?xml version="1.0"?>
 <ruleset name="WordPress coding standards">
+	<!-- Check for cross-version support for PHP 5.6 and higher. -->
+	<config name="testVersion" value="5.6-"/>
+
 	<config name="ignore_warnings_on_exit" value="1" /><!-- Ignore warnings for now. -->
 
 	<file>.</file><!-- Lint all PHP files by default. -->

From 0fa0e46ca02db41024df2c0c5cf6a2395d27648f Mon Sep 17 00:00:00 2001
From: Marco Pereirinha <marco.pereirinha@xwp.co>
Date: Mon, 30 Nov 2020 18:25:04 +0000
Subject: [PATCH 2/3] Make sure to include textdomain

---
 phpcs.xml.dist | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/phpcs.xml.dist b/phpcs.xml.dist
index e9f8e9237..2194c075a 100644
--- a/phpcs.xml.dist
+++ b/phpcs.xml.dist
@@ -15,6 +15,12 @@
 	<!-- Includes WordPress-Core, WordPress-Docs and WordPress-Extra rulesets. -->
 	<rule ref="WordPress" />
 
+	<rule ref="WordPress.WP.I18n">
+		<properties>
+			<property name="text_domain" type="array" value="cloudinary" />
+		</properties>
+	</rule>
+
 	<!-- Include WP VIP coding standard checks -->
 	<rule ref="WordPress-VIP-Go" />
 	<rule ref="WordPressVIPMinimum" />

From 5cd5e482ce307249fca6339b466157fdddf52e9a Mon Sep 17 00:00:00 2001
From: Marco Pereirinha <marco.pereirinha@xwp.co>
Date: Mon, 30 Nov 2020 18:30:27 +0000
Subject: [PATCH 3/3] Add text domain

---
 php/class-plugin.php                                          | 2 +-
 php/class-settings-page.php                                   | 2 +-
 ui-definitions/tabs/dashboard-content.php                     | 2 +-
 ui-definitions/tabs/settings-global-transformations.php       | 4 ++--
 ui-definitions/tabs/settings-global-video-transformations.php | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/php/class-plugin.php b/php/class-plugin.php
index 202ae777c..e4045e330 100644
--- a/php/class-plugin.php
+++ b/php/class-plugin.php
@@ -576,7 +576,7 @@ public function force_visit_plugin_site_link( $plugin_meta, $plugin_file, $plugi
 			$plugin_site_link = sprintf(
 				'<a href="%s">%s</a>',
 				esc_url( $plugin_data['PluginURI'] ),
-				__( 'Visit plugin site' )
+				__( 'Visit plugin site', 'cloudinary' )
 			);
 			if ( ! in_array( $plugin_site_link, $plugin_meta, true ) ) {
 				$plugin_meta[] = $plugin_site_link;
diff --git a/php/class-settings-page.php b/php/class-settings-page.php
index 9978c9af7..786650c02 100644
--- a/php/class-settings-page.php
+++ b/php/class-settings-page.php
@@ -653,7 +653,7 @@ public function footer() {
 	 */
 	public function get_ui() {
 		$defaults = array(
-			'save_button_label' => __( 'Save Changes' ),
+			'save_button_label' => __( 'Save Changes', 'cloudinary' ),
 			'capability'        => 'manage_options',
 			'tabs'              => array(),
 		);
diff --git a/ui-definitions/tabs/dashboard-content.php b/ui-definitions/tabs/dashboard-content.php
index 9f44d8094..f27afb8e5 100644
--- a/ui-definitions/tabs/dashboard-content.php
+++ b/ui-definitions/tabs/dashboard-content.php
@@ -98,7 +98,7 @@
 			<p><span class="dashicons dashicons-image-crop"></span> <?php echo wp_kses_post( $manage_text ); ?></p>
 		<?php endif; ?>
 		<p><span class="dashicons dashicons-welcome-learn-more"></span>
-			<a href="https://cloudinary.com/documentation/wordpress_integration" target="_blank"> <?php esc_html_e( 'Learn more about getting started' ); ?></a></p>
+			<a href="https://cloudinary.com/documentation/wordpress_integration" target="_blank"> <?php esc_html_e( 'Learn more about getting started', 'cloudinary' ); ?></a></p>
 	</div>
 </div>
 <?php if ( ! empty( $video_url ) ) : ?>
diff --git a/ui-definitions/tabs/settings-global-transformations.php b/ui-definitions/tabs/settings-global-transformations.php
index 1c9782537..041e27bb3 100644
--- a/ui-definitions/tabs/settings-global-transformations.php
+++ b/ui-definitions/tabs/settings-global-transformations.php
@@ -37,7 +37,7 @@
 				'enable_breakpoints' => true,
 			),
 			// translators: Placeholders are numerical ranges or min and max.
-			'suffix'            => sprintf( __( 'Valid values: %1$d – %2$d.' ), 3, 200 ),
+			'suffix'            => sprintf( __( 'Valid values: %1$d – %2$d.', 'cloudinary' ), 3, 200 ),
 		),
 		'bytes_step'         => array(
 			'label'       => __( 'Byte step', 'cloudinary' ),
@@ -144,7 +144,7 @@
 			'contextual'        => true, // Flags the field to be used in a contextual basis. i.e. taxonomies.
 			'context'           => 'image',
 			'sanitize_callback' => 'trim',
-			'error_notice'      => __( 'Format and Quality cannot be used in free form.' ),
+			'error_notice'      => __( 'Format and Quality cannot be used in free form.', 'cloudinary' ),
 			'type'              => 'textarea',
 		),
 		'image_preview'      => array(
diff --git a/ui-definitions/tabs/settings-global-video-transformations.php b/ui-definitions/tabs/settings-global-video-transformations.php
index e3bd4def4..8a512ea8f 100644
--- a/ui-definitions/tabs/settings-global-video-transformations.php
+++ b/ui-definitions/tabs/settings-global-video-transformations.php
@@ -111,7 +111,7 @@
 			'contextual'        => true, // Flags the field to be used in a contextual basis. i.e. taxonomies.
 			'context'           => 'video',
 			'sanitize_callback' => 'trim',
-			'error_notice'      => __( 'Format and Quality cannot be used in free form.' ),
+			'error_notice'      => __( 'Format and Quality cannot be used in free form.', 'cloudinary' ),
 		),
 		'video_preview'       => array(
 			'label'      => __( 'Preview', 'cloudinary' ),