From 6c15580633d7d30a7c2d6dab0ad3295c1d285d57 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Czerpak?= <lukasz.czerpak@cloudinary.com>
Date: Tue, 4 Jun 2024 16:01:27 +0200
Subject: [PATCH] fix: lcp incorrectly handled in results parser

---
 cloudinary/apiCaller.js | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/cloudinary/apiCaller.js b/cloudinary/apiCaller.js
index d7546ba..c12750e 100644
--- a/cloudinary/apiCaller.js
+++ b/cloudinary/apiCaller.js
@@ -100,12 +100,14 @@ const sendToCloudinary = (imagesArray, batchSize, dpr, metaData, quality, cb, ro
     }
     // move lcp
     const lcpIdx = parsed.imagesTestResults.findIndex((i) => i.tags.includes('lcp'));
-    metaData.lcp = {
-      isImage: metaData.lcpEvent.type === 'image',
-      analyzed: parsed.imagesTestResults.splice(lcpIdx, 1)[0],
-      event: metaData.lcpEvent,
-    };
-    delete (metaData.lcpEvent);
+    if (lcpIdx >= 0) {
+      metaData.lcp = {
+        isImage: metaData.lcpEvent.type === 'image',
+        analyzed: parsed.imagesTestResults.splice(lcpIdx, 1)[0],
+        event: metaData.lcpEvent,
+      };
+      delete (metaData.lcpEvent);
+    }
     Object.assign(parsed.resultSumm, metaData);
     cb(null, {status: 'success', data: parsed});
   });