New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add health/liveliness check for kube-router #80

Closed
murali-reddy opened this Issue Jul 27, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@murali-reddy
Member

murali-reddy commented Jul 27, 2017

We need to add health/liveliness check for the kube-router pods in cases where the kube-router daemon exits (for e.g #78) for problems that occur running daemon over a period of time. Adding such checks would atleast trigger kubernetes to redeploy the pod. While it may hide errors till we notice atleast service will be available.

@SEJeff

This comment has been minimized.

Show comment
Hide comment
@SEJeff

SEJeff Oct 5, 2017

Contributor

What do you envision a liveness probe for kube-router actually checking? I'd assuming something about the bpg status, but what makes sense?

For webapps, I'll generally do the db equiv of SELECT 1

Contributor

SEJeff commented Oct 5, 2017

What do you envision a liveness probe for kube-router actually checking? I'd assuming something about the bpg status, but what makes sense?

For webapps, I'll generally do the db equiv of SELECT 1

@murali-reddy

This comment has been minimized.

Show comment
Hide comment
@murali-reddy

murali-reddy Oct 6, 2017

Member

@SEJeff at the minimum periodic control loops are able to sync configurations (to ipvs, iptables etc) to the desired state. failing which liveliness check should fail.

Member

murali-reddy commented Oct 6, 2017

@SEJeff at the minimum periodic control loops are able to sync configurations (to ipvs, iptables etc) to the desired state. failing which liveliness check should fail.

@roffe roffe self-assigned this Feb 2, 2018

@roffe roffe removed the help wanted label Feb 5, 2018

@roffe

This comment has been minimized.

Show comment
Hide comment
@roffe

roffe Feb 5, 2018

Collaborator

Working on this here right now.

Collaborator

roffe commented Feb 5, 2018

Working on this here right now.

@roffe roffe referenced this issue Feb 6, 2018

Merged

Healthchecks #298

@roffe roffe closed this in #298 Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment