adds explicit check for existing tunnel to avoid partial matches #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmenn LGTM. Thanks for catching this issue and fixing this. Really appreciate for being persistent and fixing this. |
|
if someone wants to test this, an image is available at |
|
I just made a release just for this issue https://github.com/cloudnativelabs/kube-router/releases/tag/v0.2.0-beta.6 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current stings.Contains passes checks when there is are similar IPs
Ex:
the two ips exist
10.1.73.7&10.1.73.72where in the latter the tunnel will pass the condition for the former. This issue was encountered multiple times when there are similar IPs with the last octets sharing values. This has fixed the issue in our current environment.