Add Support for BGP Prepend #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Jun 29, 2018
pkg/options/options.go
Outdated
| // "Password that cluster-node BGP servers will use to authenticate one another when \"--nodes-full-mesh\" is set.") | ||
| fs.StringVarP(&s.VLevel, "v", "v", "0", "log level for V logs") | ||
| fs.Uint16Var(&s.HealthPort, "health-port", 20244, "Health check port, 0 = Disabled") | ||
| fs.BoolVar(&s.PathPrepend, "path-prepend", false, "tktk") |
There was a problem hiding this comment.
Not sure we need this, we should just turn on path prepend if it's found in the annotations.
es
force-pushed
the
support-bgp-prepend
branch
4 times, most recently
from
b7d3e1b to
4faf426
Compare
|
PR ready for 👀 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #469
For traffic shaping purposes, you may want to prepend the AS path announced to peers.
This PR enables that on a per-node basis with annotations:
kube-router.io/path-prepend.as: AS number to be prependedkube-router.io/path-prepend.repeat-n: number of times to prepend ASN