Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make test' on osx with BUILD_IN_DOCKER=true #660

Merged
merged 1 commit into from Feb 6, 2019

Conversation

lucasmundim
Copy link
Contributor

The import github.com/docker/libnetwork/ipvs from pkg/controllers/proxy/network_services_controller.go only builds on linux so 'go generate' from %_moq.go target needs to run inside docker when BUILD_IN_DOCKER is true.

Fixes #659

@murali-reddy
Copy link
Member

thanks @lucasmundim

LGTM

@murali-reddy murali-reddy merged commit 34666a1 into cloudnativelabs:master Feb 6, 2019
@lucasmundim lucasmundim deleted the fix_osx branch February 7, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants