Skip to content

Prefer node PodCIDR from an annotation #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

Prefer node PodCIDR from an annotation #720

merged 1 commit into from
Apr 25, 2019

Conversation

@dparalen
Copy link
Contributor

Current implementation never considers the "kube-router.io/pod-cidr"
annotation when creating an ipset for the node pod network CIDR.
The Node.Spec.PodCIDR is always used instead.

This patch prefers the annotation PodCIDR over the Node.Spec.PodCIDR

@dparalen
Prefer node PodCIDR from an annotation
774993e 
Current implementation never considers the "kube-router.io/pod-cidr"
annotation when creating an ipset for the node pod network CIDR.
The Node.Spec.PodCIDR is always used instead.

This patch prefers the annotation PodCIDR over the Node.Spec.PodCIDR
@dparalen
Copy link
Contributor Author

Hi all,
just to add a bit more context, I've run into an K8s node pod CIDR API issue the other day, that manifests in kube-router as the following error log:

E0425 13:34:14.081520    3889 network_routes_controller.go:262] Error synchronizing ipsets: Failed to sync Pod Subnets ipset: ipset v6.34: Syntax error: cannot parse : resolving to IPv4 address failed

After a bit of debugging, it turns out the issue is the empty string from the undefined value of Node.Spec.PodCIDR. This happens inspite of the node being annotaded with kube-router.io/pod-cidr.

@murali-reddy
Copy link
Member

thanks @dparalen LGTM

@murali-reddy murali-reddy merged commit 7181d6f into cloudnativelabs:master Apr 25, 2019
@dparalen
Copy link
Contributor Author

@murali-reddy thanks for a very quick response!

@dparalen dparalen deleted the prefer_annotation_node_pod_cidr branch April 25, 2019 18:31
@bhcleek bhcleek mentioned this pull request Feb 1, 2020
Closed
mk01 pushed a commit to mk01/kube-router-ipv6 that referenced this pull request Mar 12, 2020
@dparalen @mk01
Prefer node PodCIDR from an annotation (cloudnativelabs#720)
573feb3 
Current implementation never considers the "kube-router.io/pod-cidr"
annotation when creating an ipset for the node pod network CIDR.
The Node.Spec.PodCIDR is always used instead.

This patch prefers the annotation PodCIDR over the Node.Spec.PodCIDR

(cherry picked from commit 7181d6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dparalen @murali-reddy