push multi-arch images to the dev registry #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrueg
reviewed
Apr 28, 2020
mrueg
reviewed
Apr 28, 2020
aauren
approved these changes
May 2, 2020
There was a problem hiding this comment.
@rmb938 Just a few nitpics with the shell code, but overall looks good! Thanks for your contribution.
@murali-reddy since you handle more of the travis stuff, does the intent here look good to you?
aauren
reviewed
May 2, 2020
|
@aauren How does that look? I put quotes and |
|
|
mrueg
pushed a commit
to mrueg/kube-router
that referenced
this pull request
May 10, 2020
* push multi-arch images to the dev registry
* cleam things up with a array of arches
* missed setting a GOARCH
* put quotes and {} everywhere
* one of these isn't a variable
FabienZouaoui
pushed a commit
to SirDataFR/kube-router
that referenced
this pull request
May 11, 2020
* push multi-arch images to the dev registry
* cleam things up with a array of arches
* missed setting a GOARCH
* put quotes and {} everywhere
* one of these isn't a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #887