Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds annotation processor #2

Merged
merged 15 commits into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@schnatterer
Copy link
Member

commented Apr 25, 2019

  • No dependencies,
  • easier to handle at runtime thant loading the versionName from a file

@schnatterer schnatterer requested a review from sdorra Apr 25, 2019

@sdorra
Copy link
Member

left a comment

Looks very good, except the main-class problem

@@ -38,15 +38,14 @@
<packaging>jar</packaging>

<properties>
<mainClass>com.cloudogu.versionname.App</mainClass>
<mainClass>com.cloudogu.versionname.AppWithoutDeps</mainClass>

This comment has been minimized.

Copy link
@sdorra

sdorra Jun 26, 2019

Member

If i run this example i get a main class not found error. Reverting the change for this line fixes the problem for me.

This comment has been minimized.

Copy link
@schnatterer

schnatterer Jun 27, 2019

Author Member

Nice finding! The integration test on Jenkins would also have found it, if it had been run.
We now have Jenkins building also PRs and it's green after I fixed the change requested.
Thanks for the review.

@schnatterer schnatterer force-pushed the schnatterer:develop branch from 25318ff to 3c5a01e Jun 27, 2019

@schnatterer schnatterer merged commit 7977ad2 into cloudogu:develop Jun 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.