From 5a53fc838cce45ea5b1f778519212e1f02d3cc4b Mon Sep 17 00:00:00 2001 From: Taimoor Aslam Date: Thu, 23 Oct 2025 10:23:28 +0200 Subject: [PATCH 1/5] fix(greenhouse): convert null to undefined --- .changeset/breezy-hotels-make.md | 6 + .changeset/orange-eagles-drum.md | 7 + apps/doop/package.json | 4 +- apps/greenhouse/package.json | 4 +- apps/greenhouse/src/components/Extension.tsx | 2 +- apps/heureka/package.json | 4 +- apps/supernova/package.json | 4 +- apps/supernova/src/lib/urlStateUtils.ts | 8 +- pnpm-lock.yaml | 270 +++++-------------- 9 files changed, 99 insertions(+), 210 deletions(-) create mode 100644 .changeset/breezy-hotels-make.md create mode 100644 .changeset/orange-eagles-drum.md diff --git a/.changeset/breezy-hotels-make.md b/.changeset/breezy-hotels-make.md new file mode 100644 index 0000000000..48822cf1a0 --- /dev/null +++ b/.changeset/breezy-hotels-make.md @@ -0,0 +1,6 @@ +--- +"@cloudoperators/juno-app-greenhouse": patch +--- + +- While converting legacy state replace `null` with `undefined` otherwise the route validation would fail. +- Update tanstack router to fix issue where the basepath would be overwritten while redirection. diff --git a/.changeset/orange-eagles-drum.md b/.changeset/orange-eagles-drum.md new file mode 100644 index 0000000000..92002b8c2c --- /dev/null +++ b/.changeset/orange-eagles-drum.md @@ -0,0 +1,7 @@ +--- +"@cloudoperators/juno-app-supernova": patch +"@cloudoperators/juno-app-heureka": patch +"@cloudoperators/juno-app-doop": patch +--- + +Update tanstack router to fix issue where the basepath would be overwritten while redirection. diff --git a/apps/doop/package.json b/apps/doop/package.json index 8463a177d9..a9dd48e7f9 100644 --- a/apps/doop/package.json +++ b/apps/doop/package.json @@ -17,7 +17,7 @@ "@cloudoperators/juno-config": "workspace:*", "@tanstack/react-query": "5.62.2", "@tailwindcss/vite": "4.1.13", - "@tanstack/router-plugin": "1.131.25", + "@tanstack/router-plugin": "1.133.22", "@testing-library/jest-dom": "6.8.0", "@testing-library/react": "16.3.0", "@types/react": "19.1.8", @@ -47,7 +47,7 @@ "@cloudoperators/juno-messages-provider": "workspace:*", "@cloudoperators/juno-ui-components": "workspace:*", "@cloudoperators/juno-url-state-provider": "workspace:*", - "@tanstack/react-router": "1.131.25", + "@tanstack/react-router": "1.133.22", "react": "19.1.0", "react-dom": "19.1.0" } diff --git a/apps/greenhouse/package.json b/apps/greenhouse/package.json index c99554c014..b57a164e90 100644 --- a/apps/greenhouse/package.json +++ b/apps/greenhouse/package.json @@ -17,7 +17,7 @@ "devDependencies": { "@cloudoperators/juno-config": "workspace:*", "@tailwindcss/vite": "4.1.13", - "@tanstack/router-plugin": "1.131.25", + "@tanstack/router-plugin": "1.133.22", "@testing-library/jest-dom": "6.8.0", "@testing-library/react": "16.3.0", "@types/lodash": "4.17.16", @@ -58,7 +58,7 @@ "@cloudoperators/juno-oauth": "workspace:*", "@cloudoperators/juno-ui-components": "workspace:*", "@cloudoperators/juno-url-state-provider": "workspace:*", - "@tanstack/react-router": "1.131.25", + "@tanstack/react-router": "1.133.22", "lodash": "4.17.21" } } diff --git a/apps/greenhouse/src/components/Extension.tsx b/apps/greenhouse/src/components/Extension.tsx index 088e4e0e58..2b4c3508a7 100644 --- a/apps/greenhouse/src/components/Extension.tsx +++ b/apps/greenhouse/src/components/Extension.tsx @@ -50,7 +50,7 @@ function Extension({ id, config, auth, appProps }: ExtensionProps) { ? { embedded: true, token: auth?.JWT, - basePath: `${router.basepath}/${config.id}`, + basePath: `${router.basepath === "/" ? "" : router.basepath}/${config.id}`, enableHashedRouting: appProps?.enableHashedRouting || false, } : { auth: auth }), diff --git a/apps/heureka/package.json b/apps/heureka/package.json index 5f9df6dbc6..be1bb1d6d4 100644 --- a/apps/heureka/package.json +++ b/apps/heureka/package.json @@ -32,7 +32,7 @@ "@cloudoperators/juno-ui-components": "workspace:*", "@cloudoperators/juno-url-state-provider": "workspace:*", "@tanstack/react-query": "5.89.0", - "@tanstack/react-router": "1.131.25", + "@tanstack/react-router": "1.133.22", "lodash": "4.17.21", "react": "19.1.0", "react-dom": "19.1.0" @@ -44,7 +44,7 @@ "@graphql-codegen/typescript": "4.1.6", "@graphql-codegen/typescript-operations": "4.6.1", "@graphql-codegen/typescript-react-apollo": "4.3.3", - "@tanstack/router-plugin": "1.131.25", + "@tanstack/router-plugin": "1.133.22", "@tailwindcss/vite": "4.1.13", "@testing-library/jest-dom": "6.8.0", "@testing-library/react": "16.3.0", diff --git a/apps/supernova/package.json b/apps/supernova/package.json index 15b4ef243e..b8a84f952a 100644 --- a/apps/supernova/package.json +++ b/apps/supernova/package.json @@ -19,7 +19,7 @@ "@cloudoperators/juno-config": "workspace:*", "@tailwindcss/vite": "4.1.13", "@tanstack/react-query": "5.62.2", - "@tanstack/router-plugin": "1.131.25", + "@tanstack/router-plugin": "1.133.22", "@testing-library/jest-dom": "6.6.3", "@testing-library/react": "16.3.0", "@types/react": "19.1.8", @@ -50,7 +50,7 @@ "@cloudoperators/juno-messages-provider": "workspace:*", "@cloudoperators/juno-ui-components": "workspace:*", "@cloudoperators/juno-url-state-provider": "workspace:*", - "@tanstack/react-router": "1.131.25", + "@tanstack/react-router": "1.133.22", "react": "19.1.0", "react-dom": "19.1.0", "react-error-boundary": "4.1.2" diff --git a/apps/supernova/src/lib/urlStateUtils.ts b/apps/supernova/src/lib/urlStateUtils.ts index b1c8bb7bb4..ffa42d4c85 100644 --- a/apps/supernova/src/lib/urlStateUtils.ts +++ b/apps/supernova/src/lib/urlStateUtils.ts @@ -16,8 +16,12 @@ export const readLegacyUrlState = (state: any) => { const activeFilters = state?.[ACTIVE_FILTERS] const pausedFilters = state?.[PAUSED_FILTERS] const searchTerm = state?.[SEARCH_TERM] - const predefinedFilter = !isNaN(state?.[ACTIVE_PREDEFINED_FILTER]) ? state?.[ACTIVE_PREDEFINED_FILTER] : undefined // for some reason old state return NaN if the value not present - const showDetailsFor = !isNaN(state?.[DETAILS_FOR]) ? state?.[DETAILS_FOR] : undefined // for some reason old state return NaN if the value not present + const predefinedFilter = + !isNaN(state?.[ACTIVE_PREDEFINED_FILTER]) && state?.[ACTIVE_PREDEFINED_FILTER] !== null + ? state?.[ACTIVE_PREDEFINED_FILTER] + : undefined + const showDetailsFor = + !isNaN(state?.[DETAILS_FOR]) && state?.[DETAILS_FOR] !== null ? state?.[DETAILS_FOR] : undefined const activeTab = state?.[ACTIVE_TAB] const silencesRegEx = state?.[SILENCE_REG_EX] const silencesStatus = state?.[SILENCE_STATUS] diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index c8e111f58e..62e16d3cbb 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -170,8 +170,8 @@ importers: specifier: workspace:* version: link:../../packages/url-state-provider '@tanstack/react-router': - specifier: 1.131.25 - version: 1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0) + specifier: 1.133.22 + version: 1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0) react: specifier: 19.1.0 version: 19.1.0 @@ -189,8 +189,8 @@ importers: specifier: 5.62.2 version: 5.62.2(react@19.1.0) '@tanstack/router-plugin': - specifier: 1.131.25 - version: 1.131.25(@tanstack/react-router@1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) + specifier: 1.133.22 + version: 1.133.22(@tanstack/react-router@1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) '@testing-library/jest-dom': specifier: 6.8.0 version: 6.8.0 @@ -334,8 +334,8 @@ importers: specifier: workspace:* version: link:../../packages/url-state-provider '@tanstack/react-router': - specifier: 1.131.25 - version: 1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0) + specifier: 1.133.22 + version: 1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0) lodash: specifier: 4.17.21 version: 4.17.21 @@ -347,8 +347,8 @@ importers: specifier: 4.1.13 version: 4.1.13(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0)) '@tanstack/router-plugin': - specifier: 1.131.25 - version: 1.131.25(@tanstack/react-router@1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) + specifier: 1.133.22 + version: 1.133.22(@tanstack/react-router@1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) '@testing-library/jest-dom': specifier: 6.8.0 version: 6.8.0 @@ -425,8 +425,8 @@ importers: specifier: 5.89.0 version: 5.89.0(react@19.1.0) '@tanstack/react-router': - specifier: 1.131.25 - version: 1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0) + specifier: 1.133.22 + version: 1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0) lodash: specifier: 4.17.21 version: 4.17.21 @@ -459,8 +459,8 @@ importers: specifier: 4.1.13 version: 4.1.13(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0)) '@tanstack/router-plugin': - specifier: 1.131.25 - version: 1.131.25(@tanstack/react-router@1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) + specifier: 1.133.22 + version: 1.133.22(@tanstack/react-router@1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) '@testing-library/jest-dom': specifier: 6.8.0 version: 6.8.0 @@ -561,8 +561,8 @@ importers: specifier: workspace:* version: link:../../packages/url-state-provider '@tanstack/react-router': - specifier: 1.131.25 - version: 1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0) + specifier: 1.133.22 + version: 1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0) react: specifier: 19.1.0 version: 19.1.0 @@ -583,8 +583,8 @@ importers: specifier: 5.62.2 version: 5.62.2(react@19.1.0) '@tanstack/router-plugin': - specifier: 1.131.25 - version: 1.131.25(@tanstack/react-router@1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) + specifier: 1.133.22 + version: 1.133.22(@tanstack/react-router@1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8) '@testing-library/jest-dom': specifier: 6.6.3 version: 6.6.3 @@ -1031,10 +1031,6 @@ packages: '@adobe/css-tools@4.4.2': resolution: {integrity: sha512-baYZExFpsdkBNuvGKTKWCwKH57HRZLVtycZS05WTQNVOiXVSeAki3nU35zlRbToeMW8aHlJfyS+1C4BOv27q0A==} - '@ampproject/remapping@2.3.0': - resolution: {integrity: sha512-30iZtAPgz+LTIYoeivqYo853f02jBYSd5uGnGpkFV0M3xOt9aN73erkgYAmZU43x4VfqcnLxW9Kpg3R5LC4YYw==} - engines: {node: '>=6.0.0'} - '@apollo/client@3.14.0': resolution: {integrity: sha512-0YQKKRIxiMlIou+SekQqdCo0ZTHxOcES+K8vKB53cIDpwABNR0P0yRzPgsbgcj3zRJniD93S/ontsnZsCLZrxQ==} peerDependencies: @@ -1076,10 +1072,6 @@ packages: resolution: {integrity: sha512-60X7qkglvrap8mn1lh2ebxXdZYtUcpd7gsmy9kLaBJ4i/WdY8PqTSdxyA8qraikqKQK5C1KRBKXqznrVapyNaw==} engines: {node: '>=6.9.0'} - '@babel/core@7.28.0': - resolution: {integrity: sha512-UlLAnTPrFdNGoFtbSXwcGFQBtQZJCNjaN6hQNP3UPvuNXT1i82N26KL3dZeIpNalWywr9IuQuncaAfUaS1g6sQ==} - engines: {node: '>=6.9.0'} - '@babel/core@7.28.4': resolution: {integrity: sha512-2BCOP7TN8M+gVDj7/ht3hsaO/B/n5oDbiAyyvnRlNOs+u1o+JWNYTQrmpuNp1/Wq2gcFrI01JAW+paEKDMx/CA==} engines: {node: '>=6.9.0'} @@ -1088,10 +1080,6 @@ packages: resolution: {integrity: sha512-ZGhA37l0e/g2s1Cnzdix0O3aLYm66eF8aufiVteOgnwxgnRP8GoyMj7VWsgWnQbVKXyge7hqrFh2K2TQM6t1Hw==} engines: {node: '>=6.9.0'} - '@babel/generator@7.28.0': - resolution: {integrity: sha512-lJjzvrbEeWrhB4P3QBsH7tey117PjLZnDbLiQEKjQ/fNJTjuq4HSqgFA+UNSwZT8D7dxxbnuSBMsa1lrWzKlQg==} - engines: {node: '>=6.9.0'} - '@babel/generator@7.28.3': resolution: {integrity: sha512-3lSpxGgvnmZznmBkCRnVREPUFJv2wrv9iAoFDvADJc0ypmdOxdUtcLeBgBJ6zE0PMeTKnxeQzyk0xTBq4Ep7zw==} engines: {node: '>=6.9.0'} @@ -1133,12 +1121,6 @@ packages: resolution: {integrity: sha512-0gSFWUPNXNopqtIPQvlD5WgXYI5GY2kP2cCvoT8kczjbfcfuIljTbcWrulD1CIPIX2gt1wghbDy08yE1p+/r3w==} engines: {node: '>=6.9.0'} - '@babel/helper-module-transforms@7.27.3': - resolution: {integrity: sha512-dSOvYwvyLsWBeIRyOeHXp5vPj5l1I011r52FM1+r1jCERv+aFXYk4whgQccYEGYxK2H3ZAIA8nuPkQ0HaUo3qg==} - engines: {node: '>=6.9.0'} - peerDependencies: - '@babel/core': ^7.0.0 - '@babel/helper-module-transforms@7.28.3': resolution: {integrity: sha512-gytXUbs8k2sXS9PnQptz5o0QnpLL51SwASIORY6XaBKF88nsOT0Zw9szLqlSGQDP/4TljBAD5y98p2U1fqkdsw==} engines: {node: '>=6.9.0'} @@ -1185,24 +1167,10 @@ packages: resolution: {integrity: sha512-zdf983tNfLZFletc0RRXYrHrucBEg95NIFMkn6K9dbeMYnsgHaSBGcQqdsCSStG2PYwRre0Qc2NNSCXbG+xc6g==} engines: {node: '>=6.9.0'} - '@babel/helpers@7.27.6': - resolution: {integrity: sha512-muE8Tt8M22638HU31A3CgfSUciwz1fhATfoVai05aPXGor//CdWDCbnlY1yvBPo07njuVOCNGCSp/GTt12lIug==} - engines: {node: '>=6.9.0'} - '@babel/helpers@7.28.4': resolution: {integrity: sha512-HFN59MmQXGHVyYadKLVumYsA9dBFun/ldYxipEjzA4196jpLZd8UjEEBLkbEkvfYreDqJhZxYAWFPtrfhNpj4w==} engines: {node: '>=6.9.0'} - '@babel/parser@7.27.5': - resolution: {integrity: sha512-OsQd175SxWkGlzbny8J3K8TnnDD0N3lrIUtB92xwyRpzaenGZhxDvxN/JgU00U3CDZNj9tPuDJ5H0WS4Nt3vKg==} - engines: {node: '>=6.0.0'} - hasBin: true - - '@babel/parser@7.28.0': - resolution: {integrity: sha512-jVZGvOxOuNSsuQuLRTh13nU0AogFlw32w/MT+LV6D3sP5WdbW61E77RnkbaO2dUvmPAYrBDJXGn5gGS6tH4j8g==} - engines: {node: '>=6.0.0'} - hasBin: true - '@babel/parser@7.28.4': resolution: {integrity: sha512-yZbBqeM6TkpP9du/I2pUZnJsRMGGvOuIrhjzC1AwHwW+6he4mni6Bp/m8ijn0iOuZuPI2BfkCoSRunpyjnrQKg==} engines: {node: '>=6.0.0'} @@ -1689,10 +1657,6 @@ packages: resolution: {integrity: sha512-LPDZ85aEJyYSd18/DkjNh4/y1ntkE5KwUHWTiqgRxruuZL2F1yuHligVHLvcHY2vMHXttKFpJn6LwfI7cw7ODw==} engines: {node: '>=6.9.0'} - '@babel/traverse@7.28.0': - resolution: {integrity: sha512-mGe7UK5wWyh0bKRfupsUchrQGqvDbZDbKJw+kcRGSmdHVYrv+ltd0pnpDTVpiTqnaBru9iEvA8pz8W46v0Amwg==} - engines: {node: '>=6.9.0'} - '@babel/traverse@7.28.4': resolution: {integrity: sha512-YEzuboP2qvQavAcjgQNVgsvHIDv6ZpwXvcvjmyySP2DIMuByS/6ioU5G9pYrWHM6T2YDfc7xga9iNzYOs12CFQ==} engines: {node: '>=6.9.0'} @@ -1701,10 +1665,6 @@ packages: resolution: {integrity: sha512-ETyHEk2VHHvl9b9jZP5IHPavHYk57EhanlRRuae9XCpb/j5bDCbPPMOBfCWhnl/7EDJz0jEMCi/RhccCE8r1+Q==} engines: {node: '>=6.9.0'} - '@babel/types@7.28.2': - resolution: {integrity: sha512-ruv7Ae4J5dUYULmeXw1gmb7rYRz57OWCPM57pHojnLq/3Z1CK2lNSLTCVjxVk1F/TZHwOZZrOWi0ur95BbLxNQ==} - engines: {node: '>=6.9.0'} - '@babel/types@7.28.4': resolution: {integrity: sha512-bkFqkLhh3pMBUQQkpVgWDWq/lqzc2678eUyDlTBhRqhCHFguYYGM0Efga7tYk4TogG/3x0EEl66/OQ+WGbWB/Q==} engines: {node: '>=6.9.0'} @@ -2511,9 +2471,6 @@ packages: '@jridgewell/trace-mapping@0.3.25': resolution: {integrity: sha512-vNk6aEwybGtawWmy/PzwnGDOjCkLWSD2wqvjGGAgOAwCGWySYXfYoxt00IJkTF+8Lb57DwOb3Aa0o9CApepiYQ==} - '@jridgewell/trace-mapping@0.3.30': - resolution: {integrity: sha512-GQ7Nw5G2lTu/BtHTKfXhKHok2WGetd4XYcVKGx00SjAk8GMwgJM3zr6zORiPGuOE+/vkc90KtTosSSvaCjKb2Q==} - '@jridgewell/trace-mapping@0.3.31': resolution: {integrity: sha512-zzNR+SdQSDJzc8joaeP8QQoCQr8NuYx2dIIytl1QeBEZHJ9uW6hebsrYgbz8hJwUQao3TWCMtmfV8Nu1twOLAw==} @@ -3211,8 +3168,8 @@ packages: peerDependencies: vite: ^5.2.0 || ^6 || ^7 - '@tanstack/history@1.131.2': - resolution: {integrity: sha512-cs1WKawpXIe+vSTeiZUuSBy8JFjEuDgdMKZFRLKwQysKo8y2q6Q1HvS74Yw+m5IhOW1nTZooa6rlgdfXcgFAaw==} + '@tanstack/history@1.133.19': + resolution: {integrity: sha512-Y866qBVVprdQkmO0/W1AFBI8tiQy398vFeIwP+VrRWCOzs3VecxSVzAvaOM4iHfkJz81fFAZMhLLjDVoPikD+w==} engines: {node: '>=12'} '@tanstack/query-core@5.62.2': @@ -3231,8 +3188,8 @@ packages: peerDependencies: react: ^18 || ^19 - '@tanstack/react-router@1.131.25': - resolution: {integrity: sha512-xUf5m5c3OVVSnrTMGqFeCvaBUibl/GEHuBwC5xOkApli5UCTfoFG+viSrG12so4oDL8XcxmpDwiFvf31MMmusA==} + '@tanstack/react-router@1.133.22': + resolution: {integrity: sha512-0tg2yoXVMvvgR3UdOhEX9ICmgZ/Ou/I8VOl07exSYEJYfyCr5nhtB/62F9NGbuUZVrJnCzc8Rz0e4/MYU18pIg==} engines: {node: '>=12'} peerDependencies: react: '>=18.0.0 || >=19.0.0' @@ -3250,22 +3207,22 @@ packages: react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 - '@tanstack/router-core@1.131.25': - resolution: {integrity: sha512-SXAwjki0dXjDxc4KWMluDecarDb2DxQQkDWDy//JhV1nw3QbIc7HvNr9ryG0bPOKZirVLBroB3wGBvEtv0R2mA==} + '@tanstack/router-core@1.133.20': + resolution: {integrity: sha512-cO8E6XA0vMX2BaPZck9kfgXK76e6Lqo13GmXEYxtXshmW8cIlgcLHhBDKnI/sCjIy9OPY2sV1qrGHtcxJy/4ew==} engines: {node: '>=12'} - '@tanstack/router-generator@1.131.25': - resolution: {integrity: sha512-CHO68bjDU8hc6Li803OhJNzJ0+peCuKWS4cYqRRwlVVAa4C/ZMLjSq5UOqHtZRnffuZsS6ZaoT6w2F6chjHZHg==} + '@tanstack/router-generator@1.133.20': + resolution: {integrity: sha512-63lhmNNoVfqTgnSx5MUnEl/QBKSN6hA1sWLhZSQhCjLp9lrWbCXM8l9QpG3Tgzq/LdX7jjDMf783sUL4p4NbYw==} engines: {node: '>=12'} - '@tanstack/router-plugin@1.131.25': - resolution: {integrity: sha512-8XJeHyLSJ0X0nh/onIx/oMqtet3+yrQiqlIacXzYlFqUjdv5G5XWJCs4Z3S6Ctf3vMDLBHKlf+pEb4AMqkQ0Mw==} + '@tanstack/router-plugin@1.133.22': + resolution: {integrity: sha512-VVUazrxqFyon9bFSFY2mysgTbQAH5BV8kP8Gq1IHd7AxlboRW9tnj6TQcy8KGgG/KPCbKB9CFZtvSheKqrAVQg==} engines: {node: '>=12'} peerDependencies: '@rsbuild/core': '>=1.0.2' - '@tanstack/react-router': ^1.131.25 - vite: '>=5.0.0 || >=6.0.0' - vite-plugin-solid: ^2.11.2 + '@tanstack/react-router': ^1.133.22 + vite: '>=5.0.0 || >=6.0.0 || >=7.0.0' + vite-plugin-solid: ^2.11.10 webpack: '>=5.92.0' peerDependenciesMeta: '@rsbuild/core': @@ -3279,8 +3236,8 @@ packages: webpack: optional: true - '@tanstack/router-utils@1.131.2': - resolution: {integrity: sha512-sr3x0d2sx9YIJoVth0QnfEcAcl+39sQYaNQxThtHmRpyeFYNyM2TTH+Ud3TNEnI3bbzmLYEUD+7YqB987GzhDA==} + '@tanstack/router-utils@1.133.19': + resolution: {integrity: sha512-WEp5D2gPxvlLDRXwD/fV7RXjYtqaqJNXKB/L6OyZEbT+9BG/Ib2d7oG9GSUZNNMGPGYAlhBUOi3xutySsk6rxA==} engines: {node: '>=12'} '@tanstack/store@0.7.0': @@ -3289,8 +3246,8 @@ packages: '@tanstack/virtual-core@3.13.12': resolution: {integrity: sha512-1YBOJfRHV4sXUmWsFSf5rQor4Ss82G8dQWLRbnk3GA4jeP8hQt1hxXh0tmflpC0dz3VgEv/1+qwPyLeWkQuPFA==} - '@tanstack/virtual-file-routes@1.131.2': - resolution: {integrity: sha512-VEEOxc4mvyu67O+Bl0APtYjwcNRcL9it9B4HKbNgcBTIOEalhk+ufBl4kiqc8WP1sx1+NAaiS+3CcJBhrqaSRg==} + '@tanstack/virtual-file-routes@1.133.19': + resolution: {integrity: sha512-IKwZENsK7owmW1Lm5FhuHegY/SyQ8KqtL/7mTSnzoKJgfzhrrf9qwKB1rmkKkt+svUuy/Zw3uVEpZtUzQruWtA==} engines: {node: '>=12'} '@testing-library/dom@10.4.0': @@ -4171,8 +4128,8 @@ packages: convert-source-map@2.0.0: resolution: {integrity: sha512-Kvp459HrV2FEJ1CAsi1Ku+MY3kasH19TFykTz2xWmMeq6bk2NU3XXvfJ+Q61m0xktWwt+1HSYf3JZsTms3aRJg==} - cookie-es@1.2.2: - resolution: {integrity: sha512-+W7VmiVINB+ywl1HGXJXmrqkOhpKrIiVZV6tQuV54ZyQC7MMuBt81Vc336GMLoHBq5hV/F9eXgt5Mnx0Rha5Fg==} + cookie-es@2.0.0: + resolution: {integrity: sha512-RAj4E421UYRgqokKUmotqAwuplYw15qtdXfY+hGzgCJ/MBjCVZcSoHK/kH9kocfjRjcDME7IiDWR/1WX1TM2Pg==} cookie@0.7.2: resolution: {integrity: sha512-yki5XnKuf750l50uGTllt6kKILY4nQ1eNIQatoXEByZ5dWgnKqbnqmTrBE5B4N7lrMJKQ2ytWMiTO2o0v6Ew/w==} @@ -7392,11 +7349,6 @@ snapshots: '@adobe/css-tools@4.4.2': {} - '@ampproject/remapping@2.3.0': - dependencies: - '@jridgewell/gen-mapping': 0.3.8 - '@jridgewell/trace-mapping': 0.3.25 - '@apollo/client@3.14.0(@types/react@19.1.8)(graphql-ws@6.0.5(graphql@16.11.0)(ws@8.18.2))(graphql@16.11.0)(react-dom@19.1.0(react@19.1.0))(react@19.1.0)': dependencies: '@graphql-typed-document-node/core': 3.2.0(graphql@16.11.0) @@ -7476,26 +7428,6 @@ snapshots: '@babel/compat-data@7.28.0': {} - '@babel/core@7.28.0': - dependencies: - '@ampproject/remapping': 2.3.0 - '@babel/code-frame': 7.27.1 - '@babel/generator': 7.28.0 - '@babel/helper-compilation-targets': 7.27.2 - '@babel/helper-module-transforms': 7.27.3(@babel/core@7.28.0) - '@babel/helpers': 7.27.6 - '@babel/parser': 7.28.0 - '@babel/template': 7.27.2 - '@babel/traverse': 7.28.0 - '@babel/types': 7.28.2 - convert-source-map: 2.0.0 - debug: 4.4.1 - gensync: 1.0.0-beta.2 - json5: 2.2.3 - semver: 6.3.1 - transitivePeerDependencies: - - supports-color - '@babel/core@7.28.4': dependencies: '@babel/code-frame': 7.27.1 @@ -7519,19 +7451,11 @@ snapshots: '@babel/generator@7.27.5': dependencies: '@babel/parser': 7.28.4 - '@babel/types': 7.27.6 + '@babel/types': 7.28.4 '@jridgewell/gen-mapping': 0.3.8 '@jridgewell/trace-mapping': 0.3.25 jsesc: 3.1.0 - '@babel/generator@7.28.0': - dependencies: - '@babel/parser': 7.28.4 - '@babel/types': 7.28.4 - '@jridgewell/gen-mapping': 0.3.13 - '@jridgewell/trace-mapping': 0.3.30 - jsesc: 3.1.0 - '@babel/generator@7.28.3': dependencies: '@babel/parser': 7.28.4 @@ -7599,15 +7523,6 @@ snapshots: transitivePeerDependencies: - supports-color - '@babel/helper-module-transforms@7.27.3(@babel/core@7.28.0)': - dependencies: - '@babel/core': 7.28.0 - '@babel/helper-module-imports': 7.27.1 - '@babel/helper-validator-identifier': 7.27.1 - '@babel/traverse': 7.28.0 - transitivePeerDependencies: - - supports-color - '@babel/helper-module-transforms@7.28.3(@babel/core@7.28.4)': dependencies: '@babel/core': 7.28.4 @@ -7662,24 +7577,11 @@ snapshots: transitivePeerDependencies: - supports-color - '@babel/helpers@7.27.6': - dependencies: - '@babel/template': 7.27.2 - '@babel/types': 7.28.4 - '@babel/helpers@7.28.4': dependencies: '@babel/template': 7.27.2 '@babel/types': 7.28.4 - '@babel/parser@7.27.5': - dependencies: - '@babel/types': 7.28.4 - - '@babel/parser@7.28.0': - dependencies: - '@babel/types': 7.28.4 - '@babel/parser@7.28.4': dependencies: '@babel/types': 7.28.4 @@ -7760,11 +7662,6 @@ snapshots: '@babel/core': 7.28.4 '@babel/helper-plugin-utils': 7.27.1 - '@babel/plugin-syntax-jsx@7.27.1(@babel/core@7.28.0)': - dependencies: - '@babel/core': 7.28.0 - '@babel/helper-plugin-utils': 7.27.1 - '@babel/plugin-syntax-jsx@7.27.1(@babel/core@7.28.4)': dependencies: '@babel/core': 7.28.4 @@ -7775,11 +7672,6 @@ snapshots: '@babel/core': 7.28.4 '@babel/helper-plugin-utils': 7.27.1 - '@babel/plugin-syntax-typescript@7.27.1(@babel/core@7.28.0)': - dependencies: - '@babel/core': 7.28.0 - '@babel/helper-plugin-utils': 7.27.1 - '@babel/plugin-syntax-typescript@7.27.1(@babel/core@7.28.4)': dependencies: '@babel/core': 7.28.4 @@ -8291,20 +8183,8 @@ snapshots: '@babel/template@7.27.2': dependencies: '@babel/code-frame': 7.27.1 - '@babel/parser': 7.27.5 - '@babel/types': 7.27.6 - - '@babel/traverse@7.28.0': - dependencies: - '@babel/code-frame': 7.27.1 - '@babel/generator': 7.28.0 - '@babel/helper-globals': 7.28.0 - '@babel/parser': 7.28.0 - '@babel/template': 7.27.2 - '@babel/types': 7.28.2 - debug: 4.4.1 - transitivePeerDependencies: - - supports-color + '@babel/parser': 7.28.4 + '@babel/types': 7.28.4 '@babel/traverse@7.28.4': dependencies: @@ -8323,11 +8203,6 @@ snapshots: '@babel/helper-string-parser': 7.27.1 '@babel/helper-validator-identifier': 7.27.1 - '@babel/types@7.28.2': - dependencies: - '@babel/helper-string-parser': 7.27.1 - '@babel/helper-validator-identifier': 7.27.1 - '@babel/types@7.28.4': dependencies: '@babel/helper-string-parser': 7.27.1 @@ -9411,7 +9286,7 @@ snapshots: dependencies: '@jridgewell/set-array': 1.2.1 '@jridgewell/sourcemap-codec': 1.5.5 - '@jridgewell/trace-mapping': 0.3.25 + '@jridgewell/trace-mapping': 0.3.31 '@jridgewell/remapping@2.3.5': dependencies: @@ -9435,11 +9310,6 @@ snapshots: '@jridgewell/resolve-uri': 3.1.2 '@jridgewell/sourcemap-codec': 1.5.5 - '@jridgewell/trace-mapping@0.3.30': - dependencies: - '@jridgewell/resolve-uri': 3.1.2 - '@jridgewell/sourcemap-codec': 1.5.5 - '@jridgewell/trace-mapping@0.3.31': dependencies: '@jridgewell/resolve-uri': 3.1.2 @@ -10105,7 +9975,7 @@ snapshots: tailwindcss: 4.1.13 vite: 7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0) - '@tanstack/history@1.131.2': {} + '@tanstack/history@1.133.19': {} '@tanstack/query-core@5.62.2': {} @@ -10121,11 +9991,11 @@ snapshots: '@tanstack/query-core': 5.89.0 react: 19.1.0 - '@tanstack/react-router@1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0)': + '@tanstack/react-router@1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0)': dependencies: - '@tanstack/history': 1.131.2 + '@tanstack/history': 1.133.19 '@tanstack/react-store': 0.7.0(react-dom@19.1.0(react@19.1.0))(react@19.1.0) - '@tanstack/router-core': 1.131.25 + '@tanstack/router-core': 1.133.20 isbot: 5.1.29 react: 19.1.0 react-dom: 19.1.0(react@19.1.0) @@ -10145,21 +10015,21 @@ snapshots: react: 19.1.0 react-dom: 19.1.0(react@19.1.0) - '@tanstack/router-core@1.131.25': + '@tanstack/router-core@1.133.20': dependencies: - '@tanstack/history': 1.131.2 + '@tanstack/history': 1.133.19 '@tanstack/store': 0.7.0 - cookie-es: 1.2.2 + cookie-es: 2.0.0 seroval: 1.3.2 seroval-plugins: 1.3.2(seroval@1.3.2) tiny-invariant: 1.3.3 tiny-warning: 1.0.3 - '@tanstack/router-generator@1.131.25': + '@tanstack/router-generator@1.133.20': dependencies: - '@tanstack/router-core': 1.131.25 - '@tanstack/router-utils': 1.131.2 - '@tanstack/virtual-file-routes': 1.131.2 + '@tanstack/router-core': 1.133.20 + '@tanstack/router-utils': 1.133.19 + '@tanstack/virtual-file-routes': 1.133.19 prettier: 3.6.2 recast: 0.23.11 source-map: 0.7.6 @@ -10168,37 +10038,39 @@ snapshots: transitivePeerDependencies: - supports-color - '@tanstack/router-plugin@1.131.25(@tanstack/react-router@1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8)': + '@tanstack/router-plugin@1.133.22(@tanstack/react-router@1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0))(vite@7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0))(webpack@5.99.8)': dependencies: - '@babel/core': 7.28.0 - '@babel/plugin-syntax-jsx': 7.27.1(@babel/core@7.28.0) - '@babel/plugin-syntax-typescript': 7.27.1(@babel/core@7.28.0) + '@babel/core': 7.28.4 + '@babel/plugin-syntax-jsx': 7.27.1(@babel/core@7.28.4) + '@babel/plugin-syntax-typescript': 7.27.1(@babel/core@7.28.4) '@babel/template': 7.27.2 - '@babel/traverse': 7.28.0 - '@babel/types': 7.28.2 - '@tanstack/router-core': 1.131.25 - '@tanstack/router-generator': 1.131.25 - '@tanstack/router-utils': 1.131.2 - '@tanstack/virtual-file-routes': 1.131.2 + '@babel/traverse': 7.28.4 + '@babel/types': 7.28.4 + '@tanstack/router-core': 1.133.20 + '@tanstack/router-generator': 1.133.20 + '@tanstack/router-utils': 1.133.19 + '@tanstack/virtual-file-routes': 1.133.19 babel-dead-code-elimination: 1.0.10 chokidar: 3.6.0 unplugin: 2.3.4 zod: 3.25.76 optionalDependencies: - '@tanstack/react-router': 1.131.25(react-dom@19.1.0(react@19.1.0))(react@19.1.0) + '@tanstack/react-router': 1.133.22(react-dom@19.1.0(react@19.1.0))(react@19.1.0) vite: 7.1.7(@types/node@24.3.2)(jiti@2.5.1)(lightningcss@1.30.1)(sass@1.81.1)(terser@5.39.2)(tsx@4.19.4)(yaml@2.8.0) webpack: 5.99.8 transitivePeerDependencies: - supports-color - '@tanstack/router-utils@1.131.2': + '@tanstack/router-utils@1.133.19': dependencies: '@babel/core': 7.28.4 - '@babel/generator': 7.28.0 - '@babel/parser': 7.28.0 + '@babel/generator': 7.28.3 + '@babel/parser': 7.28.4 '@babel/preset-typescript': 7.27.1(@babel/core@7.28.4) ansis: 4.1.0 diff: 8.0.2 + pathe: 2.0.3 + tinyglobby: 0.2.15 transitivePeerDependencies: - supports-color @@ -10206,7 +10078,7 @@ snapshots: '@tanstack/virtual-core@3.13.12': {} - '@tanstack/virtual-file-routes@1.131.2': {} + '@tanstack/virtual-file-routes@1.133.19': {} '@testing-library/dom@10.4.0': dependencies: @@ -10982,9 +10854,9 @@ snapshots: babel-dead-code-elimination@1.0.10: dependencies: '@babel/core': 7.28.4 - '@babel/parser': 7.28.0 - '@babel/traverse': 7.28.0 - '@babel/types': 7.28.2 + '@babel/parser': 7.28.4 + '@babel/traverse': 7.28.4 + '@babel/types': 7.28.4 transitivePeerDependencies: - supports-color @@ -11316,7 +11188,7 @@ snapshots: convert-source-map@2.0.0: {} - cookie-es@1.2.2: {} + cookie-es@2.0.0: {} cookie@0.7.2: {} From c436fa52c192d01d638b7e6cde7d58d15077b29d Mon Sep 17 00:00:00 2001 From: Taimoor Aslam Date: Thu, 23 Oct 2025 10:52:21 +0200 Subject: [PATCH 2/5] chore(juno): change how we redirect to default page --- apps/doop/src/routes/index.tsx | 8 +++++++- apps/heureka/src/routes/index.tsx | 8 +++++++- apps/supernova/src/routes/index.tsx | 8 +++++++- 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/apps/doop/src/routes/index.tsx b/apps/doop/src/routes/index.tsx index c7f0e8cc4b..e53bff9bb0 100644 --- a/apps/doop/src/routes/index.tsx +++ b/apps/doop/src/routes/index.tsx @@ -6,5 +6,11 @@ import { createFileRoute, redirect } from "@tanstack/react-router" export const Route = createFileRoute("/")({ - loader: () => redirect({ to: "/violations", search: (prev) => ({ ...prev }) }), // redirect to the default /violations page + beforeLoad: () => { + // eslint-disable-next-line @typescript-eslint/only-throw-error + throw redirect({ + to: "/violations", + search: (prev) => ({ ...prev }), + }) + }, }) diff --git a/apps/heureka/src/routes/index.tsx b/apps/heureka/src/routes/index.tsx index c11e9992e4..6f7c5d119e 100644 --- a/apps/heureka/src/routes/index.tsx +++ b/apps/heureka/src/routes/index.tsx @@ -6,5 +6,11 @@ import { createFileRoute, redirect } from "@tanstack/react-router" export const Route = createFileRoute("/")({ - loader: () => redirect({ to: "/services", search: (prev) => ({ ...prev }) }), // redirect to the default /services page + beforeLoad: () => { + // eslint-disable-next-line @typescript-eslint/only-throw-error + throw redirect({ + to: "/services", + search: (prev) => ({ ...prev }), + }) + }, }) diff --git a/apps/supernova/src/routes/index.tsx b/apps/supernova/src/routes/index.tsx index 7672e28c92..84c8b59161 100644 --- a/apps/supernova/src/routes/index.tsx +++ b/apps/supernova/src/routes/index.tsx @@ -6,5 +6,11 @@ import { createFileRoute, redirect } from "@tanstack/react-router" export const Route = createFileRoute("/")({ - loader: () => redirect({ to: "/alerts", search: (prev) => ({ ...prev }) }), // redirect to the default /services page + beforeLoad: () => { + // eslint-disable-next-line @typescript-eslint/only-throw-error + throw redirect({ + to: "/alerts", + search: (prev) => ({ ...prev }), + }) + }, }) From 072c7dd2fec29c0d7254303291528f1c56addacf Mon Sep 17 00:00:00 2001 From: Taimoor Aslam Date: Thu, 23 Oct 2025 11:49:38 +0200 Subject: [PATCH 3/5] chore(supernova): remove manual normalization of legacy state --- apps/supernova/src/lib/urlStateUtils.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/apps/supernova/src/lib/urlStateUtils.ts b/apps/supernova/src/lib/urlStateUtils.ts index ffa42d4c85..30fc04d61d 100644 --- a/apps/supernova/src/lib/urlStateUtils.ts +++ b/apps/supernova/src/lib/urlStateUtils.ts @@ -16,12 +16,8 @@ export const readLegacyUrlState = (state: any) => { const activeFilters = state?.[ACTIVE_FILTERS] const pausedFilters = state?.[PAUSED_FILTERS] const searchTerm = state?.[SEARCH_TERM] - const predefinedFilter = - !isNaN(state?.[ACTIVE_PREDEFINED_FILTER]) && state?.[ACTIVE_PREDEFINED_FILTER] !== null - ? state?.[ACTIVE_PREDEFINED_FILTER] - : undefined - const showDetailsFor = - !isNaN(state?.[DETAILS_FOR]) && state?.[DETAILS_FOR] !== null ? state?.[DETAILS_FOR] : undefined + const predefinedFilter = state?.[ACTIVE_PREDEFINED_FILTER] + const showDetailsFor = state?.[DETAILS_FOR] const activeTab = state?.[ACTIVE_TAB] const silencesRegEx = state?.[SILENCE_REG_EX] const silencesStatus = state?.[SILENCE_STATUS] From 9f7dfacf4894281bdfdd67c40c13a083ef0d3738 Mon Sep 17 00:00:00 2001 From: Taimoor Aslam Date: Thu, 23 Oct 2025 11:50:38 +0200 Subject: [PATCH 4/5] chore(juno): update changesets --- .changeset/breezy-hotels-make.md | 6 ------ .changeset/cute-seas-drive.md | 6 ++++++ .changeset/orange-eagles-drum.md | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) delete mode 100644 .changeset/breezy-hotels-make.md create mode 100644 .changeset/cute-seas-drive.md diff --git a/.changeset/breezy-hotels-make.md b/.changeset/breezy-hotels-make.md deleted file mode 100644 index 48822cf1a0..0000000000 --- a/.changeset/breezy-hotels-make.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -"@cloudoperators/juno-app-greenhouse": patch ---- - -- While converting legacy state replace `null` with `undefined` otherwise the route validation would fail. -- Update tanstack router to fix issue where the basepath would be overwritten while redirection. diff --git a/.changeset/cute-seas-drive.md b/.changeset/cute-seas-drive.md new file mode 100644 index 0000000000..ab7bc6684a --- /dev/null +++ b/.changeset/cute-seas-drive.md @@ -0,0 +1,6 @@ +--- +"@cloudoperators/juno-app-supernova": patch +--- + +- Update tanstack router to fix issue where the basepath would be overwritten while redirection. +- Remove manual normalization part of legacy state to `undefined` that is no longer needed with latest version of the router. diff --git a/.changeset/orange-eagles-drum.md b/.changeset/orange-eagles-drum.md index 92002b8c2c..75df019fbe 100644 --- a/.changeset/orange-eagles-drum.md +++ b/.changeset/orange-eagles-drum.md @@ -1,5 +1,5 @@ --- -"@cloudoperators/juno-app-supernova": patch +"@cloudoperators/juno-app-greenhouse": patch "@cloudoperators/juno-app-heureka": patch "@cloudoperators/juno-app-doop": patch --- From 9bcbbc6cc2c9b6b95fc6fd4cd5d459bfd7320381 Mon Sep 17 00:00:00 2001 From: Taimoor Aslam Date: Thu, 23 Oct 2025 12:07:58 +0200 Subject: [PATCH 5/5] test(supernova): remove test --- apps/supernova/src/lib/urlStateUtils.test.ts | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/apps/supernova/src/lib/urlStateUtils.test.ts b/apps/supernova/src/lib/urlStateUtils.test.ts index 579d229be2..24b943f5f4 100644 --- a/apps/supernova/src/lib/urlStateUtils.test.ts +++ b/apps/supernova/src/lib/urlStateUtils.test.ts @@ -40,18 +40,6 @@ describe("readLegacyUrlState", () => { silencesRegEx: "regexPattern", }) }) - - it("should handle NaN values for predefinedFilter and showDetailsFor", () => { - const state = { - p: NaN, - d: NaN, - } - - const result = readLegacyUrlState(state) - - expect(result.predefinedFilter).toBeUndefined() - expect(result.showDetailsFor).toBeUndefined() - }) }) describe("getFiltersForUrl", () => {