Fix shutdown #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

osterman merged 1 commit into master from fix-shutdown

Jan 29, 2019

Contributor

osterman commented Jan 29, 2019 •

edited

Loading

what

Gracefully exit the right way
Rename /boom endpoint to /shutdown (more professional and clear)
Use log.Printf instead of fmt.Printf for logging so we get date/time
Added updated deploy.yaml (forgot to commit)

why

Exiting using a system call causes process to exit before buffer is flushed


          Fix shutdown

cee9033

osterman requested review from aknysh and goruha

January 29, 2019 05:26

goruha approved these changes

View reviewed changes

osterman merged commit 1000755 into master

osterman deleted the fix-shutdown branch

January 29, 2019 05:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet