Extend usability of nginx-ingress chart #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it is
Why
http
, not80
).service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'
hard coded as a value, I implemented a minor change in the design of the chart to include this annotation in the service so long as use-proxy-protocol is set totrue
(it is by default still). This annotation should not be added while terminating SSL at an ELB.Backwards compatability