Need unique names for IAM role and policy

[bwmetcalf]

Describe the Bug

Enabling forwarder_log_enabled and forwarder_vpc_logs_enabled in different module calls causes both to create the IAM role and policy used by the lambda functions using the same name. While the former creates a lambda function using the name dev-test-datadog-forwarder-log and the latter uses dev-test-datadog-forwarder-vpclogs which allows them to coexist, they both use the name dev-test-datadog-forwarder-lambda for the role name and policy which is going to fail.

Note, It is possible to enable both of the above within the same module call to this module and they will share the one IAM role and policy.

Expected Behavior

Each type of lambda that can be enabled by this module should use unique names for all resources created.

Steps to Reproduce

Call this module twice with one enabling forwarder_log_enabled and the other enabling forwarder_vpc_logs_enabled.

[nitrocode]

It should be tied to the context vars like namespace, environment, stage, name, attributes. Did you try changing those for each module instantiation ?

[bwmetcalf]

We have well-defined values for namespace, stage and name for all of our projects and changing them for this would disrupt our naming conventions. I tried passing in environment but it doesn't change anything. Same for attributes. Furthermore, attributes in main.tf is defined here:

terraform-aws-datadog-lambda-forwarder/main.tf

Line 41 in 864b68c

attributes = ["forwarder-lambda"]

I'm suggesting that each lambda function should have its own role and policy and those names should end in the same string that the actual lambda function does. For example, forwarder-log for lambda-log.tf, forwarder-vpclogs for lambda-vpclogs.tf and so forth.

I'm good for now as I'm enabling both in the same module call, but I think this would be an improvement.

[jamengual]

@bwmetcalf Please send a PR our way, it does make sense to use different roles in case you enable multiple lambda functions in the same account

[aknysh]

@bwmetcalf the latest release has the changes that you wanted.
Thanks for pointing it out