Skip to content

Fix logic when enabled = false. Update tests. Update module versions and GitHub workflows #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aknysh merged 6 commits into from
May 17, 2023
Merged

Fix logic when enabled = false. Update tests. Update module versions and GitHub workflows #53

aknysh merged 6 commits into from
May 17, 2023

Conversation

@aknysh
Copy link
Member

@aknysh aknysh commented May 16, 2023 •
edited
Loading

what

  • Fix logic when enabled = false
  • Update tests
  • Update module versions and GitHub workflows

why

  • When enabled is set to false, the Terraform coalesce function gets two parameters that are either null or an empty string, and throws an error. Wrapping the coalesce function in a try function solved the issues when the module is disabled
  • Update terratests to the latest patterns. Add a test for a disabled module
  • Keep up to date

@aknysh aknysh added the minor New features that do not break anything label May 16, 2023
@aknysh aknysh requested review from Nuru, nitrocode and osterman May 16, 2023 16:51
@aknysh aknysh self-assigned this May 16, 2023
@aknysh aknysh requested review from a team as code owners May 16, 2023 16:51
@aknysh aknysh requested review from florian0410 and woz5999 May 16, 2023 16:51
@aknysh
Copy link
Member Author

aknysh commented May 16, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented May 16, 2023

/test all

1 similar comment
@aknysh
Copy link
Member Author

aknysh commented May 16, 2023

/test all

@aknysh
Copy link
Member Author

aknysh commented May 17, 2023

/terratest

@aknysh aknysh merged commit baab038 into main May 17, 2023
@aknysh aknysh deleted the fixes-for-disabled branch May 17, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman Awaiting requested review from osterman

@Nuru Nuru Awaiting requested review from Nuru

@nitrocode nitrocode Awaiting requested review from nitrocode

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 is a code owner automatically assigned from cloudposse/contributors

Assignees

@aknysh aknysh

Labels

minor New features that do not break anything

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aknysh