New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for EBS volumes created when the instance has been disabled, plus some vars description improvement #102
Conversation
- Ficing a wrong description provided for ebs_volume_encrypted in variables.tf - Changing some EBS related description to be clear those are "additional volumes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I requested a minor change.
Co-authored-by: Yonatan Koren <me@yonatankoren.com>
This Pull Request has been updated, so we're dismissing all reviews.
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a nag — I just realized we should drop the s
in local.volumes_count
to be more consistent with var.ebs_volume_count
Co-authored-by: Yonatan Koren <me@yonatankoren.com>
This Pull Request has been updated, so we're dismissing all reviews.
Co-authored-by: Yonatan Koren <me@yonatankoren.com>
Co-authored-by: Yonatan Koren <me@yonatankoren.com>
/test all |
what
Adding a local variable and a
&&
to the creation of the EBS volumes we can avoid the creation of the additional volumes if the instance creation has been disabled.references