fix(eks-cluster-example): Add eks_worker_ami_name_filter variable to the example #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, most_recent (https://github.com/cloudposse/terraform-aws-eks-workers/blob/34a43c25624a6efb3ba5d2770a601d7cb3c0d391/main.tf#L141) variable does not work as expected, if you are not going to use custom ami you should enforce usage of eks_worker_ami_name_filter variable to set the right kubernetes version for EKS workers, otherwise will be used the first version of Kubernetes supported by AWS (v1.11) for EKS workers but EKS control plane will use the version specified by kubernetes_version variable.
|
Also I've updated readme with copy-paste to avoid the differences with an example 😄 |
|
/codefresh run test |
|
/codefresh run test |
|
@aknysh done |
|
/codefresh run test |
aknysh
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, most_recent variable does not work as expected.
Enforce usage of eks_worker_ami_name_filter variable to set the right kubernetes version for EKS workers,
otherwise will be used the first version of Kubernetes supported by AWS (v1.11) for EKS workers but
EKS control plane will use the version specified by kubernetes_version variable.