Support bottlerocket ami types

[nitrocode]

what

• Support bottlerocket ami types
• Removed unused null and template providers

why

• This will allow us to support bottlerocket ami using an ami_type
• template provider removal will allow OSX M1 to use this module

references

https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html

amiType

    If the node group was deployed using a launch template with a custom AMI, then this is CUSTOM. For node groups that weren't deployed using a launch template, this is the AMI type that was specified in the node group configuration.

    Type: String

    Valid Values: AL2_x86_64 | AL2_x86_64_GPU | AL2_ARM_64 | CUSTOM | BOTTLEROCKET_ARM_64 | BOTTLEROCKET_x86_64

    Required: No

notes

• There is no GPU version of bottlerocket

Here are the following data source checks to verify backwards compatibility.

With a temporary output in ami.tf and examples/complete/outputs.tf

output "ami_regex" {
  value = local.ami_regex[local.ami_kind],
}

And setting after_cluster_joining_userdata = ["ls"] to trigger needing an ami.

ami_type = "AL2_x86_64" and ami_release_version = ["1.21.0-20211013"]

# matches amazon-eks-node-1.21-v20211013 in us-east-2
ami_regex = amazon-eks-node-1.21-v20211013

ami_type = "AL2_x86_64" and no ami_release_version

# matches amazon-eks-node-1.21-v20211013 in us-east-2
ami_regex = amazon-eks-node-1.21-*

ami_type = "BOTTLEROCKET_x86_64" and ami_release_version = ["1.2.0-ccf1b754"]

# matches bottlerocket-aws-k8s-1.21-x86_64-v1.2.0-ccf1b754 in us-east-2
ami_regex = bottlerocket-aws-k8s-1.21-x86_64-v1.2.0-ccf1b754

ami_type = "BOTTLEROCKET_x86_64" and no ami_release_version

# matches bottlerocket-aws-k8s-1.21-x86_64-v1.3.0-395b459c in us-east-2
ami_regex = bottlerocket-aws-k8s-1.21-x86_64-*

ami_type = "BOTTLEROCKET_ARM_64" and ami_release_version = ["1.2.0-ccf1b754"]

# matches bottlerocket-aws-k8s-1.21-aarch64-v1.2.0-ccf1b754 in us-east-2
ami_regex = "bottlerocket-aws-k8s-1.21-aarch64-v1.2.0-ccf1b754"

ami_type = "BOTTLEROCKET_ARM_64" and no ami_release_version

# matches bottlerocket-aws-k8s-1.21-aarch64-v1.3.0-395b459c in us-east-2
ami_regex = "bottlerocket-aws-k8s-1.21-aarch64-*"

[nitrocode]

/test all

[Nuru]

I am closing this as wontfix because I don't like it, which means it can be reopened if a consensus develops that there are good reasons to do it even though I don't like it. :-)

I don't like it because I think this is dangerous feature creep, and not necessary to achieve desired goals. Users who are not happy with the standard AMI regex should select the AMI outside of this module and then feed in the desired AMI ID via the ami_image_id input. Regular expressions are notoriously problematic, and this PR does not further parameterize the most_recent or owners inputs to the aws_ami data source, nor do I want to add those parameters. (variables.tf is already over 400 lines and I don't want to add even more options, because every option adds to the complexity of understanding and using the module and the complexity of supporting it.)

[nitrocode]

/test all

[nitrocode]

/test all

This Pull Request has been updated, so we're dismissing all reviews.

[nitrocode]

/test all

[nitrocode]

/test all

This Pull Request has been updated, so we're dismissing all reviews.

[nitrocode]

/test test/terratest

[nitrocode]

/test test/terratest