New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bottlerocket ami types #93
Conversation
/test all |
I am closing this as I don't like it because I think this is dangerous feature creep, and not necessary to achieve desired goals. Users who are not happy with the standard AMI regex should select the AMI outside of this module and then feed in the desired AMI ID via the |
/test all |
/test all |
This Pull Request has been updated, so we're dismissing all reviews.
/test all |
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
/test all |
This Pull Request has been updated, so we're dismissing all reviews.
/test test/terratest |
1 similar comment
/test test/terratest |
what
why
references
https://docs.aws.amazon.com/eks/latest/APIReference/API_Nodegroup.html
notes
Here are the following data source checks to verify backwards compatibility.
With a temporary output in
ami.tf
andexamples/complete/outputs.tf
And setting
after_cluster_joining_userdata = ["ls"]
to trigger needing an ami.ami_type = "AL2_x86_64"
andami_release_version = ["1.21.0-20211013"]
ami_type = "AL2_x86_64"
and noami_release_version
ami_type = "BOTTLEROCKET_x86_64"
andami_release_version = ["1.2.0-ccf1b754"]
ami_type = "BOTTLEROCKET_x86_64"
and noami_release_version
ami_type = "BOTTLEROCKET_ARM_64"
andami_release_version = ["1.2.0-ccf1b754"]
ami_type = "BOTTLEROCKET_ARM_64"
and noami_release_version