fix: Fix JSON and UUID type checking, add JSON test, consolidate setup.py #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
commented
Aug 1, 2023
| "six==1.16.0", | ||
| "structlog==23.1.0", | ||
| "tomli==2.0.1", | ||
| "tzdata==2023.3", |
Member
Author
There was a problem hiding this comment.
I've moved all the requirements into setup.py, and changed requirements.txt to ., so that they are the same. We can change this again later, but this should ensure that the package and dev requirements are the same for now. Only thing is that we probably don't need black here
hermanschaaf
commented
Aug 1, 2023
disq
reviewed
Aug 1, 2023
disq
approved these changes
Aug 1, 2023
yevgenypats
approved these changes
Aug 1, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 1, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.8](v0.0.7...v0.0.8) (2023-08-01) ### Bug Fixes * **deps:** Update dependency numpy to v1.25.2 ([#11](#11)) ([0d05fc8](0d05fc8)) * Fix JSON and UUID type checking, add JSON test, consolidate setup.py ([#14](#14)) ([7927d1a](7927d1a)) * Remove resolver() from schema.Table ([#15](#15)) ([c61a774](c61a774)) * SyncMigrateTableMessage should have the `pa.Schema` argument named as "table" ([#13](#13)) ([a50f0e7](a50f0e7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the type checking for JSON and UUID, and adds a very simple test for the JSON type to show correct usage.
Also consolidates requirements.txt and setup.py a bit, but it's probably still not in its final form.