fix: Scalar timestamp parsing #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken with #1095
disq
commented
Jul 21, 2023
scalar/timestamp.go
Outdated
|
|
||
| // this is used by arrow string format (time is in UTC) | ||
| const arrowStringFormat = "2006-01-02 15:04:05.999999999" | ||
| const arrowStringFormatNew = "2006-01-02 15:04:05.999999999Z" |
Member
Author
There was a problem hiding this comment.
Not adding a new line and using the one above seems to break some other things (at least in the test src plugin) probably because of older arrow versions without the Z :)
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 48.75% 47.63% -1.13%
==========================================
Files 85 85
Lines 7839 7799 -40
==========================================
- Hits 3822 3715 -107
- Misses 3682 3746 +64
- Partials 335 338 +3
☔ View full report in Codecov by Sentry. |
erezrokah
approved these changes
Jul 21, 2023
yevgenypats
reviewed
Aug 2, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Can we add some tests to that, given it's a "hot path"
Member
Author
@yevgenypats added |
yevgenypats
approved these changes
Aug 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.0](v4.4.0...v4.5.0) (2023-08-14) ### Features * Add publish command ([#1143](#1143)) ([fdd44d5](fdd44d5)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to e9683e1 ([#1144](#1144)) ([763c549](763c549)) * Scalar timestamp parsing ([#1109](#1109)) ([c15b214](c15b214)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken with #1095 (at least for the test source, which gets its data from testdata)