fix: Check record equality before generating diff #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
candiduslynx
commented
Aug 1, 2023
candiduslynx
commented
- Less data generated
- Allows to account for unordered map keys (foe CH, for example)
yevgenypats
approved these changes
Aug 1, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.4](v4.2.3...v4.2.4) (2023-08-02) ### Bug Fixes * Check record equality before generating diff ([#1123](#1123)) ([b2e6331](b2e6331)) * **deps:** Update github.com/apache/arrow/go/v13 digest to 112f949 ([#1115](#1115)) ([ed0e4e0](ed0e4e0)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 10df4b9 ([#1110](#1110)) ([636084c](636084c)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 3452eb0 ([#1114](#1114)) ([af83988](af83988)) * **deps:** Update golang.org/x/exp digest to b0cb94b ([#1116](#1116)) ([4a6dc5b](4a6dc5b)) * **deps:** Update google.golang.org/genproto digest to e0aa005 ([#1117](#1117)) ([5fa4d51](5fa4d51)) * **deps:** Update google.golang.org/genproto/googleapis/api digest to e0aa005 ([#1118](#1118)) ([939060f](939060f)) * **deps:** Update google.golang.org/genproto/googleapis/rpc digest to e0aa005 ([#1119](#1119)) ([0a9f8ea](0a9f8ea)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.9.0 ([#1112](#1112)) ([3831a88](3831a88)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.9.1 ([#1113](#1113)) ([67bc46e](67bc46e)) * **deps:** Update module github.com/klauspost/compress to v1.16.7 ([#1120](#1120)) ([e41a303](e41a303)) * **deps:** Update module github.com/pierrec/lz4/v4 to v4.1.18 ([#1121](#1121)) ([6829b63](6829b63)) * Process nulls for tested types, too (maps, lists, structs) ([#1125](#1125)) ([4a1f315](4a1f315)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Aug 2, 2023
Follow-up for #12155. Depends on: * cloudquery/plugin-sdk#1123 * cloudquery/plugin-sdk#1124 * cloudquery/plugin-sdk#1125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.