fix: Change testdata.Generate signature
#1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 48.87% 48.71% -0.16%
==========================================
Files 87 87
Lines 8037 8071 +34
==========================================
+ Hits 3928 3932 +4
- Misses 3749 3781 +32
+ Partials 360 358 -2
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Aug 21, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
🤖 I have created a release *beep* *boop* --- ## [4.5.2](v4.5.1...v4.5.2) (2023-08-21) ### Bug Fixes * Change `testdata.Generate` signature ([#1153](#1153)) ([86e717a](86e717a)) * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to 5b83d4f ([#1154](#1154)) ([8558dd1](8558dd1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.1 ([#1150](#1150)) ([b3f41b1](b3f41b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of cloudquery/cloudquery#13153
This changes the semantics of
testdata.Generatefromgenerate opts.MaxRowsrecords togenerate a single record with opts.MaxRows rows