Skip to content

feat: Update package command #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 13, 2023
Merged

feat: Update package command #1211

merged 7 commits into from
Sep 13, 2023

Conversation

@hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Sep 12, 2023 •
edited
Loading

This updates the plugin package command (previously called publish) to build executables into a dist directory that will be consumed by the cloudquery publish command for publishing to the registry.

Usage example:

go run main.go package . v1.2.3

@github-actions github-actions bot added feat and removed feat labels Sep 12, 2023
@hermanschaaf hermanschaaf requested a review from disq September 12, 2023 16:10
@github-actions github-actions bot added feat and removed feat labels Sep 12, 2023
erezrokah
erezrokah approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@erezrokah erezrokah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but doesn't the plugin already knows its own version? What's the reason to pass it via the command?

disq
disq approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erezrokah
Copy link
Member

erezrokah commented Sep 12, 2023

We can embed the version in the code like we do in https://github.com/cloudquery/cloudquery/blob/c4de5dab89fcc2845e37b5772bc462c5e8edc7ce/plugins/source/typeform/plugin/plugin.py#L14

@hermanschaaf
Copy link
Member Author

hermanschaaf commented Sep 13, 2023

. We can embed the version in the code like we do in ...

@erezrokah That might work for us, but I think we should keep it tool-agnostic as we want it to work for community plugins as well, regardless of whether they use Release Please. We may need a solution like that for Python again, but I think it will be a find-and-replace in that case. Does that make sense?

@erezrokah
Copy link
Member

erezrokah commented Sep 13, 2023

Does that make sense?

💯

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 55.49% and project coverage change: +0.07% 🎉

Comparison is base (179769a) 48.43% compared to head (fa8c1a4) 48.50%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   48.43%   48.50%   +0.07%     
==========================================
  Files          87       87              
  Lines        8104     8141      +37     
==========================================
+ Hits         3925     3949      +24     
- Misses       3825     3828       +3     
- Partials      354      364      +10
Files Changed Coverage Δ
plugin/options.go 0.00% <0.00%> (ø)
serve/package.go 55.61% <55.61%> (ø)
plugin/plugin.go 35.48% <100.00%> (+2.15%) ⬆️
serve/plugin.go 62.68% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited
Loading

⏱️ Benchmark results

Comparing with 179769a

  • Glob-8 ns/op: 101.3 ⬆️ 2.30% increase vs. 179769a

@kodiakhq kodiakhq bot merged commit 39fc65e into main Sep 13, 2023
@kodiakhq kodiakhq bot deleted the update-package-command branch September 13, 2023 10:02
@cq-bot cq-bot mentioned this pull request Sep 13, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Sep 19, 2023
@cq-bot
chore(main): Release v4.8.0 (#1210)
a734b74 
🤖 I have created a release *beep* *boop*
---


## [4.8.0](v4.7.1...v4.8.0) (2023-09-19)


### Features

* Add Checksums to package.json format ([#1217](#1217)) ([720baae](720baae))
* Add message to package command ([#1216](#1216)) ([44956d9](44956d9))
* Add shuffle scheduler ([#1218](#1218)) ([2b1ba30](2b1ba30))
* Update package command ([#1211](#1211)) ([39fc65e](39fc65e))


### Bug Fixes

* Add schema version to package.json ([#1212](#1212)) ([393c94d](393c94d))
* **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 483f6b2 ([#1209](#1209)) ([179769a](179769a))
* **deps:** Update github.com/cloudquery/arrow/go/v14 digest to ffb7089 ([#1215](#1215)) ([70f20bb](70f20bb))
* Use -dir suffix for plugin package arguments ([#1213](#1213)) ([93f9398](93f9398))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

@erezrokah erezrokah erezrokah approved these changes

@yevgenypats yevgenypats Awaiting requested review from yevgenypats

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hermanschaaf @erezrokah @disq