fix: Use -dir suffix for plugin package arguments #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested review from
erezrokah and
yevgenypats
as code owners
hermanschaaf
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
=======================================
Coverage 48.51% 48.51%
=======================================
Files 87 87
Lines 8142 8142
=======================================
Hits 3950 3950
Misses 3828 3828
Partials 364 364
☔ View full report in Codecov by Sentry. |
erezrokah
approved these changes
Sep 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
🤖 I have created a release *beep* *boop* --- ## [4.8.0](v4.7.1...v4.8.0) (2023-09-19) ### Features * Add Checksums to package.json format ([#1217](#1217)) ([720baae](720baae)) * Add message to package command ([#1216](#1216)) ([44956d9](44956d9)) * Add shuffle scheduler ([#1218](#1218)) ([2b1ba30](2b1ba30)) * Update package command ([#1211](#1211)) ([39fc65e](39fc65e)) ### Bug Fixes * Add schema version to package.json ([#1212](#1212)) ([393c94d](393c94d)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 483f6b2 ([#1209](#1209)) ([179769a](179769a)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to ffb7089 ([#1215](#1215)) ([70f20bb](70f20bb)) * Use -dir suffix for plugin package arguments ([#1213](#1213)) ([93f9398](93f9398)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we use the
-dirsuffix fairly consistently in the CloudQuery CLI, so figured we should keep it the same here.