fix: Set GOOS and GOARCH in package command #1246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
requested review from
erezrokah and
yevgenypats
as code owners
erezrokah
approved these changes
Sep 25, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
+ Coverage 48.84% 48.89% +0.05%
==========================================
Files 89 89
Lines 8310 8313 +3
==========================================
+ Hits 4059 4065 +6
+ Misses 3875 3873 -2
+ Partials 376 375 -1
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Sep 25, 2023
hermanschaaf
pushed a commit
that referenced
this pull request
Sep 25, 2023
🤖 I have created a release *beep* *boop* --- ## [4.11.0](v4.10.2...v4.11.0) (2023-09-25) ### Features * Provide User with actionable error message when no tables are configured for syncing ([#1243](#1243)) ([e53d952](e53d952)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 64e27ff ([#1245](#1245)) ([ff074f4](ff074f4)) * Set GOOS and GOARCH in package command ([#1246](#1246)) ([119f962](119f962)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that different binaries are actually built as expected. I also added a test assertion to check that the SHA256 of the resulting binaries are at least different.