feat: Add JSON schema to scheduler strategy #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 48.89% 48.96% +0.06%
==========================================
Files 89 90 +1
Lines 8313 8324 +11
==========================================
+ Hits 4065 4076 +11
Misses 3873 3873
Partials 375 375
☔ View full report in Codecov by Sentry. |
4 tasks
⏱️ Benchmark results
|
candiduslynx
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
candiduslynx
commented
Sep 29, 2023
| func randSeq(n int) string { | ||
| b := make([]rune, n) | ||
| rand.Seed(time.Now().UnixNano()) | ||
| rnd := rand.New(rand.NewSource(time.Now().UnixNano())) |
Contributor
Author
There was a problem hiding this comment.
If this is merged after #1255 the diff goes away
hermanschaaf
approved these changes
Sep 29, 2023
Member
hermanschaaf
left a comment
hermanschaaf
left a comment
There was a problem hiding this comment.
Was a bit hard to see what changed due to the file contents moving, but seems like it's mainly the addition of func (Strategy) JSONSchema() *jsonschema.Schema and a test for it?
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
🤖 I have created a release *beep* *boop* --- ## [4.12.0](v4.11.1...v4.12.0) (2023-10-02) ### Features * Add JSON schema to scheduler strategy ([#1254](#1254)) ([1cec01d](1cec01d)) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to 00efb06 ([#1257](#1257)) ([e56f6f8](e56f6f8)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to 7ded38b ([#1263](#1263)) ([332c255](332c255)) * **deps:** Update google.golang.org/genproto digest to e6e6cda ([#1258](#1258)) ([1b75050](1b75050)) * **deps:** Update google.golang.org/genproto/googleapis/api digest to e6e6cda ([#1259](#1259)) ([eb6a97d](eb6a97d)) * **deps:** Update google.golang.org/genproto/googleapis/rpc digest to e6e6cda ([#1260](#1260)) ([49940fd](49940fd)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.11.0 ([#1252](#1252)) ([41a6561](41a6561)) * **deps:** Update module github.com/getsentry/sentry-go to v0.24.1 ([#1262](#1262)) ([be03068](be03068)) * **deps:** Update module github.com/grpc-ecosystem/go-grpc-middleware/v2 to v2.0.1 ([#1261](#1261)) ([cf57d20](cf57d20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
3 tasks
kodiakhq bot
pushed a commit
to cloudquery/codegen
that referenced
this pull request
Oct 2, 2023
Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/plugin-sdk#1254
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 2, 2023
Follow-up for #13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
Follow-up for cloudquery#13876 Blocked by: - [x] invopop/jsonschema#103 - [x] invopop/jsonschema#105 - [x] cloudquery/codegen#29 - [x] cloudquery/plugin-sdk#1254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using centralized JSON schema definition instead of tagging every
scheduler.Strategyentry in plugin specs