feat: Add JSON schema for configtype.Duration
#1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candiduslynx
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
candiduslynx
force-pushed
the
feat/jsonschema/configtype/duration
branch
from
2ea2141 to
8b6ef58
Compare
⏱️ Benchmark results
|
candiduslynx
changed the title
configtype.Durationconfigtype.Duration
| Spec: `false`, | ||
| }, | ||
| }, | ||
| func() []testCase { |
Member
There was a problem hiding this comment.
nit: this syntax of appending a function that calls itself and appends the results in-line feels unnecessarily complicated, it'd be more readable to introduce a variable first and append that, like:
generatedCases := make([]testcase, 20)
for i := 0; i < 20; i++ {
generatedCases[i] = generateTestCase()
}
...
cases := append([]testCase{
{
Name: "empty",
Err: true,
Spec: `""`,
},
...,
generatedCases...
})
or have a few manually created test cases, there doesn't seem to be enough complexity here to warrant generating random cases
hermanschaaf
approved these changes
Oct 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
🤖 I have created a release *beep* *boop* --- ## [4.15.0](v4.14.1...v4.15.0) (2023-10-17) ### Features * Add JSON schema for `configtype.Duration` ([#1303](#1303)) ([5e1598b](5e1598b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.