fix(package): Only return one level down of relations when writing tables.json
#1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Oct 19, 2023
| tables = append(tables, table) | ||
| } | ||
| return tables, nil | ||
| return tables.FilterDfs(opts.Tables, opts.SkipTables, opts.SkipDependentTables) |
Member
Author
There was a problem hiding this comment.
This is needed so we set parents implicitly via Copy (see also cloudquery/cloudquery#14637)
disq
approved these changes
Oct 19, 2023
hermanschaaf
approved these changes
Oct 19, 2023
erezrokah
force-pushed
the
fix/package_tables
branch
from
0fe27d1 to
b98e3b3
Compare
Member
|
@erezrokah There's a test failure FYI (expected 2 tables but got 3) |
erezrokah
force-pushed
the
fix/package_tables
branch
from
79e1f16 to
9e422ad
Compare
⏱️ Benchmark results
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
🤖 I have created a release *beep* *boop* --- ## [4.16.1](v4.16.0...v4.16.1) (2023-10-19) ### Bug Fixes * **package:** Only return one level down of relations when writing `tables.json` ([#1321](#1321)) ([3d4ebe0](3d4ebe0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/cloudquery/cloudquery-issues/issues/690 (internal issue).
Tables.TableNames()is recursive and gets all nested names so we can't use it.Without the fix each table will have all of descendants under
relationsinstead of only the children (1 level descendants)Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)