fix: Return clearer error when team name empty or not set #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnorbury
approved these changes
Nov 2, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
🤖 I have created a release *beep* *boop* --- ## [4.17.2](v4.17.1...v4.17.2) (2023-11-02) ### Bug Fixes * **deps:** Update github.com/apache/arrow/go/v14 digest to c49e242 ([#1343](#1343)) ([8f6362e](8f6362e)) * **deps:** Update golang.org/x/xerrors digest to 104605a ([#1345](#1345)) ([5b3e9c6](5b3e9c6)) * **deps:** Update google.golang.org/genproto digest to d783a09 ([#1346](#1346)) ([2af9c70](2af9c70)) * **deps:** Update google.golang.org/genproto/googleapis/api digest to d783a09 ([#1347](#1347)) ([6f43900](6f43900)) * **deps:** Update google.golang.org/genproto/googleapis/rpc digest to d783a09 ([#1348](#1348)) ([bdf7a32](bdf7a32)) * **deps:** Update module github.com/andybalholm/brotli to v1.0.6 ([#1349](#1349)) ([2e79c6f](2e79c6f)) * **deps:** Update module github.com/bytedance/sonic to v1.10.2 ([#1350](#1350)) ([147b381](147b381)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.13.2 ([#1351](#1351)) ([d3d34e5](d3d34e5)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.13.3 ([#1352](#1352)) ([31137ad](31137ad)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.13.4 ([#1353](#1353)) ([f5c1bbe](f5c1bbe)) * Return clearer error when team name empty or not set ([#1354](#1354)) ([e82c69e](e82c69e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the error users get when the team is not set is
failed to configure quota monitor: failed to get usage: 404 Not Found. The recent CLI change in cloudquery/cloudquery#15119 will ensure that the team should mostly get set, but there can still be cases where users are in multiple teams and forget to runcloudquery switch. In such a case, a friendlier error would be helpful.