feat: Individual Table and Client rate limit #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
scheduler/scheduler.go
Outdated
| logger zerolog.Logger | ||
| concurrency int | ||
| singleTableConcurrency sync.Map | ||
| singleTableMaxConcurrency int |
Contributor
There was a problem hiding this comment.
also, maybe use negative to disable the code?
erezrokah
reviewed
Dec 12, 2023
Member
erezrokah
left a comment
erezrokah
left a comment
There was a problem hiding this comment.
Added a few comments/questions mostly. The blocking one is on making this a non breaking change
erezrokah
reviewed
Dec 12, 2023
erezrokah
approved these changes
Dec 12, 2023
candiduslynx
approved these changes
Dec 12, 2023
1 task
hermanschaaf
approved these changes
Dec 13, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
🤖 I have created a release *beep* *boop* --- ## [4.21.0](v4.20.0...v4.21.0) (2023-12-13) ### Features * Individual Table and Client rate limit ([#1411](#1411)) ([4d13b18](4d13b18)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.6.2 ([#1413](#1413)) ([f5a0d47](f5a0d47)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.14.4 ([#1408](#1408)) ([7544967](7544967)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr introduces a rate semaphore that limits the number of simultaneous go routines that can be resolving the same table + client to just 10. Prior to this a single table could be using all of the available concurrency to resolve a single table. This alleviates the problem where nested tables get throttled because the load is not spread across all client/table pairs but is concentrated on a single client and table.
I will update this PR with a benchmark case once #1410 gets merged