Skip to content

Conversation

@bbernays
Copy link
Contributor

@bbernays bbernays commented Apr 4, 2024

Summary

Keep resource version in line with the packages specified in go.mod

Copy link
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also disable automatic updates for this package?
See example in https://github.com/cloudquery/cloudquery/blob/4839d53643176cc23f69da3680d697b5257a1b8c/.github/renovate.json5#L28 (we don't need the matchFileNames part)

@github-actions
Copy link

github-actions bot commented Apr 4, 2024

⏱️ Benchmark results

  • Glob-8 ns/op: 90.66

@bbernays
Copy link
Contributor Author

bbernays commented Apr 4, 2024

Can we also disable automatic updates for this package? See example in https://github.com/cloudquery/cloudquery/blob/4839d53643176cc23f69da3680d697b5257a1b8c/.github/renovate.json5#L28 (we don't need the matchFileNames part)

@erezrokah - I will do that if I can't add tests that would catch this

@kodiakhq kodiakhq bot merged commit 601ef35 into main Apr 4, 2024
@kodiakhq kodiakhq bot deleted the fix-otel-crash branch April 4, 2024 16:08
kodiakhq bot pushed a commit that referenced this pull request Apr 4, 2024
🤖 I have created a release *beep* *boop*
---


## [4.36.5](v4.36.4...v4.36.5) (2024-04-04)


### Bug Fixes

* Update Otel Schema version ([#1605](#1605)) ([601ef35](601ef35))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@erezrokah erezrokah mentioned this pull request May 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants