fix: Normalize Windows line breaks before parsing configuration files #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
force-pushed
the
chore/add_windows_tests
branch
from
2cdb464 to
be99461
Compare
erezrokah
changed the title
erezrokah
commented
Nov 6, 2022
| @@ -1,3 +1,5 @@ | |||
| //go:build !windows | |||
Member
Author
There was a problem hiding this comment.
We don't want cross platform snapshot tests 🐰 🕳️
erezrokah
commented
Nov 6, 2022
| @@ -1,3 +1,5 @@ | |||
| //go:build !windows | |||
Member
Author
There was a problem hiding this comment.
We don't want cross platform snapshot tests 🐰 🕳️
erezrokah
commented
Nov 6, 2022
| @@ -1,3 +1,5 @@ | |||
| //go:build !windows | |||
erezrokah
commented
Nov 6, 2022
| @@ -1,3 +1,5 @@ | |||
| //go:build !windows | |||
Member
Author
|
Before we merge this we'll need to update the branch protection rules |
disq
approved these changes
Nov 7, 2022
5 tasks
yevgenypats
approved these changes
Nov 7, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.3](v1.0.2...v1.0.3) (2022-11-07) ### Bug Fixes * Allow managed clients to disable sentry logging ([#363](#363)) ([dc20388](dc20388)) * Normalize Windows line breaks before parsing configuration files ([#352](#352)) ([979e207](979e207)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #351
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)