fix: Make path a required config parameter #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
erezrokah
approved these changes
Nov 7, 2022
erezrokah
reviewed
Nov 7, 2022
| // give a small hint to help users transition from the old config format that didn't require path | ||
| officialPlugins := []string{"aws", "azure", "gcp", "digitalocean", "github", "heroku", "k8s", "okta", "terraform", "cloudflare"} | ||
| if funk.ContainsString(officialPlugins, s.Name) { | ||
| msg += fmt.Sprintf(". Hint: try setting path to cloudquery/%s in your config", s.Name) |
yevgenypats
approved these changes
Nov 7, 2022
disq
reviewed
Nov 7, 2022
| if funk.ContainsString(officialPlugins, s.Name) { | ||
| msg += fmt.Sprintf(". Hint: try setting path to cloudquery/%s in your config", s.Name) | ||
| } | ||
| return fmt.Errorf(msg) |
Member
There was a problem hiding this comment.
Should be errors.New because if msg contains % it will fail weirdly (but understandably)
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.4](v1.0.3...v1.0.4) (2022-11-08) ### Bug Fixes * Make path a required config parameter ([#368](#368)) ([77fdaf8](77fdaf8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates (and replaces) this earlier PR for making
patha required config parameter: #265We have received numerous user reports of the distinction between name and path being confusing, so rather than infer path from name in some circumstances (and not in some others), this change makes things consistent by always requiring both. I've also added a small hint for users running into this error when upgrading from earlier versions.
We will not consider this a breaking SDK change, as it doesn't change any protocols, but it will be a breaking CLI change.
idproperty instead of forcing a uniquename#317nameof the plugin #256