feat: Add NopBackend #616
Merged
feat: Add NopBackend #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
erezrokah
approved these changes
Jan 18, 2023
disq
approved these changes
Jan 24, 2023
yevgenypats
approved these changes
Jan 24, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
🤖 I have created a release *beep* *boop* --- ## [1.29.0](v1.28.0...v1.29.0) (2023-01-24) ### Features * Add NopBackend ([#616](#616)) ([79f5395](79f5395)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Nop-backend (following the naming convention set inio.NopCloser) for when no backend is specified. Using this instead ofnilwill make incremental resolvers simpler and give them one fewer pitfall to avoid, because it will no longer be necessary to guard every use ofbackendwith a nil-pointer check (see two such cases within a single resolver here, for example: https://github.com/cloudquery/cloudquery/blob/main/plugins/source/stripe/resources/services/application_fees/application_fees.go). This way resolvers don't need to care what the backend is, they can just trust that the interface is implemented.