fix: Trap terminate signal, log which signal we received #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 47.15% // Head: 47.19% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 47.15% 47.19% +0.04%
==========================================
Files 70 70
Lines 6721 6727 +6
==========================================
+ Hits 3169 3175 +6
Misses 3106 3106
Partials 446 446
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
⏱️ Benchmark results
|
disq
approved these changes
Feb 2, 2023
erezrokah
approved these changes
Feb 2, 2023
yevgenypats
approved these changes
Feb 6, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [1.34.0](v1.33.1...v1.34.0) (2023-02-07) ### Features * Add skip_dependent_tables option ([#662](#662)) ([bf34943](bf34943)) ### Bug Fixes * **logging:** Log more explicit message when OOM and other status codes occur ([#659](#659)) ([45c637b](45c637b)) * **logging:** Send more info logs when plugins are being terminated ([#657](#657)) ([6f44e1c](6f44e1c)) * Remove unused `OnlyIncrementalTables` spec property ([#661](#661)) ([f88ba7d](f88ba7d)) * Trap terminate signal, log which signal we received ([#658](#658)) ([bb39830](bb39830)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help debug issues with ECS a bit more effectively, by knowing when the source or destination plugins receive terminate signals.