-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Add table diff methods #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⏱️ Benchmark results
|
Codecov ReportBase: 46.73% // Head: 47.25% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
+ Coverage 46.73% 47.25% +0.52%
==========================================
Files 69 70 +1
Lines 6591 6802 +211
==========================================
+ Hits 3080 3214 +134
- Misses 3078 3137 +59
- Partials 433 451 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hermanschaaf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor suggestions
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
|
Didn't manage to comment but we already have a It's used in the SQLite destination with similar logic: |
Good catch, force is already implemented via spec and is the right way to go (I got a bit rusty on the SDK :) ) #668 (comment)
🤖 I have created a release *beep* *boop* --- ## [1.36.0](v1.35.0...v1.36.0) (2023-02-08) ### Features * Add table diff methods ([#668](#668)) ([f6baa82](f6baa82)) * Use Setpgid=true on Unix systems so that signals are not sent to the child process ([#664](#664)) ([2883487](2883487)) ### Bug Fixes * Remove duplicate force implementation ([#670](#670)) ([fe34554](fe34554)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thanks , good catch. removed the options thing - #670 |
Blocked by cloudquery/plugin-sdk#668 This streamlines migrations, introduce force option and in general should speed up migrations substantially as we only do now one query instead of query per table. Blocked by another take in SDK - cloudquery/plugin-sdk#688
This adds diff methods for
Table. This will help simplify migrations so we can transform the destination/database intoTablestruct and then understand what was changed/added in the same way across all destination plugins.PostgreSQL PR example - cloudquery/cloudquery#7819