-
Notifications
You must be signed in to change notification settings - Fork 26
fix: Destination testing add force tests #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⏱️ Benchmark resultsComparing with e49f593
|
|
@yevgenypats Is it wise to only test forced migrations? I think if we need a default to test, it should be non-forced, which has been our default behavior until now |
We don't really use those / use it anywhere apart from the latest postgres destination. I can add it though those tests in this PR |
Codecov ReportBase: 47.37% // Head: 57.02% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
+ Coverage 47.37% 57.02% +9.64%
==========================================
Files 70 42 -28
Lines 6792 3237 -3555
==========================================
- Hits 3218 1846 -1372
+ Misses 3124 1176 -1948
+ Partials 450 215 -235 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@hermanschaaf added proper tests for force migrations. I can also add another type of tests where in non-force it returns an error on column type change but prefer to do it in a follow-up PR after we update all destination to this sdk. |
🤖 I have created a release *beep* *boop* --- ## [1.36.1](v1.36.0...v1.36.1) (2023-02-12) ### Bug Fixes * Destination testing add force tests ([#671](#671)) ([879f843](879f843)) * Fix source log message, and some debug messages ([#673](#673)) ([e49f593](e49f593)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Add force tests