Skip to content

Conversation

@yevgenypats
Copy link
Contributor

Follow-up to this - #678

@github-actions
Copy link

github-actions bot commented Feb 12, 2023

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 10,703
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,192
  • Glob-2 ns/op: 289.2
  • TablesWithChildrenDFS-2 resources/s: 25,153
  • TablesWithChildrenRoundRobin-2 resources/s: 25,066
  • TablesWithRateLimitingDFS-2 resources/s: 28.21
  • TablesWithRateLimitingRoundRobin-2 resources/s: 837.6
  • BufferedScanner-2 ns/op: 12.34
  • LogReader-2 ns/op: 39.77

@codecov-commenter
Copy link

Codecov Report

Base: 47.23% // Head: 47.23% // No change to project coverage 👍

Coverage data is based on head (d07c6c1) compared to base (710173d).
Patch has no changes to coverable lines.

❗ Current head d07c6c1 differs from pull request most recent head 24f3cfc. Consider uploading reports for the commit 24f3cfc to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   47.23%   47.23%           
=======================================
  Files          70       70           
  Lines        6815     6815           
=======================================
  Hits         3219     3219           
  Misses       3146     3146           
  Partials      450      450           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit 77b74b2 into main Feb 12, 2023
@kodiakhq kodiakhq bot deleted the fix/dest_race_test_take2 branch February 12, 2023 15:11
kodiakhq bot pushed a commit that referenced this pull request Feb 12, 2023
🤖 I have created a release *beep* *boop*
---


## [1.36.3](v1.36.2...v1.36.3) (2023-02-12)


### Bug Fixes

* Take2 of fixing race in destination testing ([#680](#680)) ([77b74b2](77b74b2))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants