fix: Fix race in dest testing try 3 #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Feb 12, 2023
Codecov ReportBase: 47.23% // Head: 47.27% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 47.23% 47.27% +0.04%
==========================================
Files 70 70
Lines 6815 6815
==========================================
+ Hits 3219 3222 +3
+ Misses 3146 3143 -3
Partials 450 450
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
⏱️ Benchmark results
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
🤖 I have created a release *beep* *boop* --- ## [1.37.0](v1.36.3...v1.37.0) (2023-02-13) ### Features * Add unmanaged sources ([#677](#677)) ([f3e2b1d](f3e2b1d)) ### Bug Fixes * Fix race in dest testing try 3 ([#683](#683)) ([8e8f5fe](8e8f5fe)) * Make sure _cq_id unique across all dest plugins ([#685](#685)) ([a9a1173](a9a1173)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
1 task
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Feb 13, 2023
…7933) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/cloudquery/plugin-sdk](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v1.36.1` -> `v1.37.0` | | [github.com/cloudquery/plugin-sdk](https://togithub.com/cloudquery/plugin-sdk) | require | patch | `v1.36.0` -> `v1.37.0` | --- ### Release Notes <details> <summary>cloudquery/plugin-sdk</summary> ### [`v1.37.0`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.37.0) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.3...v1.37.0) ##### Features * Add unmanaged sources ([#677](cloudquery/plugin-sdk#677)) ([f3e2b1d](cloudquery/plugin-sdk@f3e2b1d)) ##### Bug Fixes * Fix race in dest testing try 3 ([#683](cloudquery/plugin-sdk#683)) ([8e8f5fe](cloudquery/plugin-sdk@8e8f5fe)) * Make sure _cq_id unique across all dest plugins ([#685](cloudquery/plugin-sdk#685)) ([a9a1173](cloudquery/plugin-sdk@a9a1173)) ## [1.36.3](cloudquery/plugin-sdk@v1.36.2...v1.36.3) (2023-02-12) ### [`v1.36.3`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.36.3) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.2...v1.36.3) ##### Bug Fixes - Take2 of fixing race in destination testing ([#​680](https://togithub.com/cloudquery/plugin-sdk/issues/680)) ([77b74b2](https://togithub.com/cloudquery/plugin-sdk/commit/77b74b2cd4c28ee5f570b008105a41d0b7e8afc8)) ### [`v1.36.2`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v1.36.2) [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v1.36.1...v1.36.2) ##### Bug Fixes - Potential database lock/race in destination testing ([#​678](https://togithub.com/cloudquery/plugin-sdk/issues/678)) ([50e683e](https://togithub.com/cloudquery/plugin-sdk/commit/50e683e7f6dfd38a25eb512c1e2417798fa832f7)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDkuMSIsInVwZGF0ZWRJblZlciI6IjM0LjEwOS4xIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite hard to debug locally cloudquery/cloudquery#7819 so sorry for influx of PRs.
My current theory is that the db is blocked on number of connections.
The next thing that I might be trying is to not to do those tests concurrently as it can cause weird things in databases and just do those sequentially.