feat: Adding premium plugin support for updating usage and monitoring quota #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mnorbury
commented
Oct 25, 2023
mnorbury
commented
- Fixing API to match the example usage
- Add a quota monitoring function
mnorbury
commented
Oct 25, 2023
| } | ||
|
|
||
| func (qc quotaChecker) startQuotaMonitor(ctx context.Context) (context.Context, func()) { | ||
| newCtx, cancel := context.WithCancel(ctx) |
Contributor
Author
There was a problem hiding this comment.
Typically a cancelable context is created by the caller, but in this case I didn't want to make the caller (plugin developer) have to write this code.
mnorbury
commented
Oct 25, 2023
| case <-newCtx.Done(): | ||
| return | ||
| case <-ticker.C: | ||
| hasQuota, err := qc.qm.HasQuota(newCtx) |
Contributor
Author
There was a problem hiding this comment.
Need to add retries to the HasQuota call.
mnorbury
commented
Oct 25, 2023
| case <-ticker.C: | ||
| hasQuota, err := qc.qm.HasQuota(newCtx) | ||
| if err != nil { | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
What should we do with an error determining the quota - since returning an error here would cancel the sync.
mnorbury
force-pushed
the
fix/make-api-compatible-with-example-plugin
branch
from
c089a68 to
84ac02c
Compare
…e parent context is cancelled to perform the final flush
mnorbury
force-pushed
the
fix/make-api-compatible-with-example-plugin
branch
2 times, most recently
from
9e3a155 to
4b86abc
Compare
mnorbury
force-pushed
the
fix/make-api-compatible-with-example-plugin
branch
from
4b86abc to
68aade0
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.