fix: When _cq_id SyncMigrateMessage not sent
#1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
bbernays
changed the title
_cq_id SyncMessage not sent
bbernays
commented
Jan 25, 2024
Comment on lines
-197
to
-199
| if cqIDCol == nil { | ||
| continue | ||
| } |
Contributor
Author
There was a problem hiding this comment.
When this occurred, no syncMigrateMessage would be sent
bbernays
changed the title
_cq_id SyncMessage not sent_cq_id SyncMigrateMessage not sent
erezrokah
reviewed
Jan 26, 2024
erezrokah
approved these changes
Jan 26, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
🤖 I have created a release *beep* *boop* --- ## [4.27.2](v4.27.1...v4.27.2) (2024-01-29) ### Bug Fixes * Better build overrides ([#1492](#1492)) ([ca5afc1](ca5afc1)) * When `_cq_id` SyncMigrateMessage not sent ([#1489](#1489)) ([d177320](d177320)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a case where no sync message would be sent