Skip to content

feat!: Remove ParentIDResolver #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022
Merged

feat!: Remove ParentIDResolver #202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dcd226
feat!: Remove ParentIDResolver
erezrokah Sep 28, 2022
df6cde0
Merge branch 'main' into feat/remove_parent_id_resolver
erezrokah Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions schema/resolvers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ func PathResolver(path string) ColumnResolver {
}
}

// ParentIDResolver resolves the cq_id from the parent
// if you want to reference the parent's primary keys use ParentResourceFieldResolver as required.
func ParentIDResolver(_ context.Context, _ ClientMeta, r *Resource, c Column) error {
return r.Set(c.Name, r.Parent.ID())
}

// ParentColumnResolver resolves a column from the parent's table data, if name isn't set the column will be set to null
func ParentColumnResolver(name string) ColumnResolver {
return func(_ context.Context, _ ClientMeta, r *Resource, c Column) error {
Expand Down