Skip to content

fix: Remove DisallowUnknownFields from Source plugin server #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2022
Merged

fix: Remove DisallowUnknownFields from Source plugin server #277

merged 1 commit into from
Oct 11, 2022

Conversation

@hermanschaaf
Copy link
Member

@hermanschaaf hermanschaaf commented Oct 11, 2022

See cloudquery/cloudquery#2612 for an explanation.

Notes:

  • We weren't using DisallowUnknownFields on the destination plugin side
  • We don't currently have a mechanism to warn about unknown fields, but we are working on it Draft: Validation warnings #272
  • This will unfortunately not fix plugins that have already been released. Our next CLI release that adds new fields will have to be breaking, but after that they can be backwards-compatible.

@github-actions github-actions bot added the fix label Oct 11, 2022
@hermanschaaf hermanschaaf merged commit 0fcf813 into main Oct 11, 2022
@hermanschaaf hermanschaaf deleted the remove-disallow-unknown-fields branch October 11, 2022 09:58
@cq-bot cq-bot mentioned this pull request Oct 11, 2022
Merged
hermanschaaf pushed a commit that referenced this pull request Oct 11, 2022
@cq-bot
chore(main): Release v0.13.2 (#278)
b6c390f 
🤖 I have created a release *beep* *boop*
---


##
[0.13.2](v0.13.1...v0.13.2)
(2022-10-11)


### Bug Fixes

* Remove DisallowUnknownFields from Source plugin server
([#277](#277))
([0fcf813](0fcf813))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yevgenypats yevgenypats yevgenypats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hermanschaaf @yevgenypats