fix: Call Release on resource semaphore #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
approved these changes
Oct 11, 2022
yevgenypats
suggested changes
Oct 11, 2022
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| defer resourcesSem.Release(1) |
Contributor
There was a problem hiding this comment.
nit: let's keep the order the same
so it should be:
defer resourceSem.Release(1) (release the resource last because we acquired it first)
defer wg.Done() (so first we release the workgroup as it was add last)
yevgenypats
approved these changes
Oct 11, 2022
hermanschaaf
pushed a commit
that referenced
this pull request
Oct 11, 2022
🤖 I have created a release *beep* *boop* --- ## [0.13.3](v0.13.2...v0.13.3) (2022-10-11) ### Bug Fixes * Call Release on resource semaphore ([#279](#279)) ([051e247](051e247)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing a
Releasecall on theresource_concurrencysemaphore.