fix: Include source path in dest to source map key #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
commented
Nov 6, 2022
| if destinationSourceMap[destination] == "" { | ||
| destinationSourceMap[destination] = source.Path + "@" + source.Version | ||
| } else if destinationSourceMap[destination] != source.Path+"@"+source.Version { | ||
| destinationToSourceKey := fmt.Sprintf("%s-%s", destination, source.Path) |
Member
Author
There was a problem hiding this comment.
It's ok to destination name and not destination.Path as those destination names are unique by definition in a single sync
yevgenypats
approved these changes
Nov 6, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
🤖 I have created a release *beep* *boop* --- ## [0.13.22](v0.13.21...v0.13.22) (2022-11-06) ### Bug Fixes * Include source path in dest to source map key ([#353](#353)) ([ac727f6](ac727f6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #350
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)