fix: Context cancelled too early for delete stale mode #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
approved these changes
Nov 9, 2022
Member
|
I'll go ahead and force merge this cc @yevgenypats |
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.1](v1.1.0...v1.1.1) (2022-11-09) ### Bug Fixes * Context cancelled too early for delete stale mode ([#377](#377)) ([cd7bf6d](cd7bf6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for this error, encountered when postgresql plugin is run with overwrite-delete-stale mode:
The reason it didn't work before is that the grouperr context gets cancelled as soon as Wait() returns. We should be using the original
ctxfor the subsequent delete stale call.This also fixes this error:
by using
os.RemoveAllso that the file is removed if it is there, or ignored otherwise.