fix: Array types #587
Merged
fix: Array types #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with a54dbe7
|
erezrokah
reviewed
Jan 9, 2023
codegen/transformers.go
Outdated
| return schema.TypeJSON, nil | ||
| case reflect.Slice: | ||
| switch v.Elem().Kind() { | ||
| case reflect.Uint8: |
Member
There was a problem hiding this comment.
Shouldn't this be in defaultGoTypeToSchemaType?
Contributor
There was a problem hiding this comment.
defaultGoTypeToSchemaType will return TypeInt in this case, effectively resulting in TypeIntArray returned
Member
Author
There was a problem hiding this comment.
there's no schema.TypeByte, so no.
candiduslynx
approved these changes
Jan 9, 2023
yevgenypats
reviewed
Jan 9, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Can we add a regression test for that?
Member
Author
@yevgenypats added |
yevgenypats
approved these changes
Jan 9, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
🤖 I have created a release *beep* *boop* --- ## [1.24.1](v1.24.0...v1.24.1) (2023-01-09) ### Bug Fixes * Array types ([#587](#587)) ([73ea82c](73ea82c)) * Sentry errors not sent ([#592](#592)) ([9f1e373](9f1e373)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP:
metadata,binary_dataandetagfields are being switched fromIntArraytoByteArrayK8s:
spec_request,status_certificateswitched fromIntArraytoByteArrayAWS:
aws_amp_workspaces.data,aws_iam_virtual_mfa_devices.base32_string_seedandqr_code_pngAzure: No changes